Bug 135342 - Web Replay: incorrect serialization code generated for enum classes inside class scope
Summary: Web Replay: incorrect serialization code generated for enum classes inside cl...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brian Burg
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-07-28 11:13 PDT by Brian Burg
Modified: 2014-07-28 12:23 PDT (History)
4 users (show)

See Also:

Attachments
Patch (17.62 KB, patch)
2014-07-28 11:28 PDT, Brian Burg 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brian Burg 2014-07-28 11:13:00 PDT 
Needed by later patches that add EncodingTraits for ResourceRequest and ResourceResponse.
Comment 1 Brian Burg 2014-07-28 11:28:03 PDT 
Created attachment 235601 [details]
Patch
Comment 2 WebKit Commit Bot 2014-07-28 11:29:35 PDT 
Attachment 235601 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/replay/scripts/tests/expected/generate-enums-with-same-base-name.json-TestReplayInputs.cpp:125:  More than one command on the same line  [whitespace/newline] [4]
ERROR: Source/JavaScriptCore/replay/scripts/tests/expected/generate-enums-with-same-base-name.json-TestReplayInputs.cpp:180:  More than one command on the same line  [whitespace/newline] [4]
Total errors found: 2 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 WebKit Commit Bot 2014-07-28 12:23:01 PDT 
Comment on attachment 235601 [details]
Patch

Clearing flags on attachment: 235601

Committed r171683: <http://trac.webkit.org/changeset/171683>
Comment 4 WebKit Commit Bot 2014-07-28 12:23:04 PDT 
All reviewed patches have been landed.  Closing bug.