RESOLVED FIXED135342
Web Replay: incorrect serialization code generated for enum classes inside class scope 
https://bugs.webkit.org/show_bug.cgi?id=135342
Summary Web Replay: incorrect serialization code generated for enum classes inside cl...
Brian Burg
Reported 2014-07-28 11:13:00 PDT
Needed by later patches that add EncodingTraits for ResourceRequest and ResourceResponse.
Attachments
Patch (17.62 KB, patch)
2014-07-28 11:28 PDT, Brian Burg 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Brian Burg
Comment 1 2014-07-28 11:28:03 PDT
Created attachment 235601 [details] Patch
WebKit Commit Bot
Comment 2 2014-07-28 11:29:35 PDT
Attachment 235601 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/replay/scripts/tests/expected/generate-enums-with-same-base-name.json-TestReplayInputs.cpp:125: More than one command on the same line [whitespace/newline] [4] ERROR: Source/JavaScriptCore/replay/scripts/tests/expected/generate-enums-with-same-base-name.json-TestReplayInputs.cpp:180: More than one command on the same line [whitespace/newline] [4] Total errors found: 2 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style.
WebKit Commit Bot
Comment 3 2014-07-28 12:23:01 PDT
Comment on attachment 235601 [details] Patch Clearing flags on attachment: 235601 Committed r171683: <http://trac.webkit.org/changeset/171683>
WebKit Commit Bot
Comment 4 2014-07-28 12:23:04 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.