Bug 135329 – Don't rely on reading applicationState from within DidEnterBackground/WillEnterForeground

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Gavin Barraclough]

API may not be stable.

[Gavin Barraclough]

Created attachment 235584 [details]
Fix

Basic browsing seems to work.

[Sam Weinig]

Comment on attachment 235584 [details]
Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=235584&action=review

I'm not clear if this makes sense to be on the WKContentView.  I believe there are some PDF related issues with that.  I need to check with Tim/Andy.

> Source/WebKit2/UIProcess/ios/WKContentView.mm:514
> +    _isBackground = TRUE;

This should be YES.

> Source/WebKit2/UIProcess/ios/WKContentView.mm:520
> +    _isBackground = FALSE;

This should be NO.

[Sam Weinig]

Comment on attachment 235584 [details]
Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=235584&action=review

> Source/WebKit2/UIProcess/ios/ProcessAssertionIOS.mm:106
> +    _appIsBackground = FALSE;

Please use NO.

> Source/WebKit2/UIProcess/ios/ProcessAssertionIOS.mm:112
> +    _appIsBackground = TRUE;

Please use YES.

[Sam Weinig]

(In reply to comment #2)
> (From update of attachment 235584 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=235584&action=review
> 
> I'm not clear if this makes sense to be on the WKContentView.  I believe there are some PDF related issues with that.  I need to check with Tim/Andy.
> 

I checked with Tim, and this is not an issue in this case. The problem was depending on WKContentView to always be parented (which in the PDF case it is not), but since we don't care about parentage in this case, it doesn't matter.  r=me.

[Gavin Barraclough]

Fixed in r171663.

[Tim Horton]

Probably at some point we should move those notification listeners to WKWebView, but not today. I think this is fine.