Bug 135324 - CSS: Fix :visited behavior for SubSelectors
Summary: CSS: Fix :visited behavior for SubSelectors
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Yusuke Suzuki
URL:
Keywords:
Depends on:
Blocks: 135293
  Show dependency treegraph
 
Reported: 2014-07-26 10:52 PDT by Yusuke Suzuki
Modified: 2014-07-28 02:49 PDT (History)
6 users (show)

See Also:


Attachments
Patch (7.50 KB, patch)
2014-07-26 11:01 PDT, Yusuke Suzuki
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from webkit-ews-15 for mac-mountainlion-wk2 (643.44 KB, application/zip)
2014-07-26 12:01 PDT, Build Bot
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Yusuke Suzuki 2014-07-26 10:52:02 PDT
Investigating the :visited behavior, I found that current :visited disable fix is only available for the selectors which doesn't has subselectors[1].

[1]: http://trac.webkit.org/browser/trunk/Source/WebCore/css/SelectorChecker.cpp?rev=171646#L214
Comment 1 Yusuke Suzuki 2014-07-26 11:01:10 PDT
Created attachment 235575 [details]
Patch
Comment 2 Yusuke Suzuki 2014-07-26 11:02:44 PDT
Comment on attachment 235575 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=235575&action=review

Added comments.

> LayoutTests/fast/history/nested-visited-test-complex.html:30
> +:visited.ok > span.ok { color: orange }

These `.ok` are added.

> LayoutTests/fast/history/sibling-visited-test-complex.html:21
> +:visited + :link.ok { color: green }

This `.ok` is added.
Comment 3 Build Bot 2014-07-26 12:01:32 PDT
Comment on attachment 235575 [details]
Patch

Attachment 235575 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/6446507314118656

New failing tests:
media/track/add-and-remove-track.html
Comment 4 Build Bot 2014-07-26 12:01:35 PDT
Created attachment 235577 [details]
Archive of layout-test-results from webkit-ews-15 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-15  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5
Comment 5 Benjamin Poulain 2014-07-28 02:06:44 PDT
Comment on attachment 235575 [details]
Patch

Yep, you are absolutely right. Good catch!
Comment 6 WebKit Commit Bot 2014-07-28 02:49:03 PDT
Comment on attachment 235575 [details]
Patch

Clearing flags on attachment: 235575

Committed r171675: <http://trac.webkit.org/changeset/171675>
Comment 7 WebKit Commit Bot 2014-07-28 02:49:06 PDT
All reviewed patches have been landed.  Closing bug.