Bug 135324 – CSS: Fix :visited behavior for SubSelectors

• Status: RESOLVED
• Resolution: FIXED
• Component: CSS

[Yusuke Suzuki]

Investigating the :visited behavior, I found that current :visited disable fix is only available for the selectors which doesn't has subselectors[1].

[1]: http://trac.webkit.org/browser/trunk/Source/WebCore/css/SelectorChecker.cpp?rev=171646#L214

[Yusuke Suzuki]

Created attachment 235575 [details]
Patch

[Yusuke Suzuki]

Comment on attachment 235575 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=235575&action=review

Added comments.

> LayoutTests/fast/history/nested-visited-test-complex.html:30
> +:visited.ok > span.ok { color: orange }

These `.ok` are added.

> LayoutTests/fast/history/sibling-visited-test-complex.html:21
> +:visited + :link.ok { color: green }

This `.ok` is added.

[Build Bot]

Comment on attachment 235575 [details]
Patch

Attachment 235575 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/6446507314118656

New failing tests:
media/track/add-and-remove-track.html

[Build Bot]

Created attachment 235577 [details]
Archive of layout-test-results from webkit-ews-15 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-15  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5

[Benjamin Poulain]

Comment on attachment 235575 [details]
Patch

Yep, you are absolutely right. Good catch!

[WebKit Commit Bot]

Comment on attachment 235575 [details]
Patch

Clearing flags on attachment: 235575

Committed r171675: <http://trac.webkit.org/changeset/171675>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.