Bug 135270 – ImageDiff builds for the simulator when running iOS layout tests

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[David Farler]

ImageDiff is a host-side tool for comparing image output from layout tests and should only ever run on the host. As it stands, there is no good way to do separate aggregate target members to build against a different SDK in Xcode, so we can provide a tool, build-imagediff, which run-webkit-tests can invoke if necessary and --no-build wasn't passed.

[David Farler]

Created attachment 235479 [details]
Patch

[Simon Fraser (smfr)]

Comment on attachment 235479 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=235479&action=review

> Tools/ChangeLog:3
> +        ImageDiff builds for the simulator when running iOS layout tests

I think this should say "Build ImageDiff for the simulator"?

[David Farler]

(In reply to comment #2)
> (From update of attachment 235479 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=235479&action=review
> 
> > Tools/ChangeLog:3
> > +        ImageDiff builds for the simulator when running iOS layout tests
> 
> I think this should say "Build ImageDiff for the simulator"?

Nope, it already builds for the simulator. The script it a shortcut to build it for the host at all times. Running it in the sim bootstrap is pretty slow and not really necessary. webkitpy will invoke it out of WebKitBuild/Debug.

[David Farler]

Committed r171686: <http://trac.webkit.org/changeset/171686>