Bug 135151 - Web Inspector: Fix unused parameter build warning
Summary: Web Inspector: Fix unused parameter build warning
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2014-07-21 23:56 PDT by Shivakumar J M
Modified: 2014-07-22 11:14 PDT (History)
9 users (show)

See Also:

Attachments
patch (1.24 KB, patch)
2014-07-22 01:52 PDT, Shivakumar J M 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from webkit-ews-09 for mac-mountainlion-wk2 (522.43 KB, application/zip)
2014-07-22 08:00 PDT, Build Bot 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Shivakumar J M 2014-07-21 23:56:09 PDT 
Fix unused parameter build warning, found in WebInspector.cpp, during build for efl wk2 port.

[ 93%] Building CXX object Source/WebKit2/CMakeFiles/WebKit2.dir/WebProcess/WebPage/WebPageGroupProxy.cpp.o
/home/shiva.jm/webkit-git/svn32bit/WebKit/Source/WebKit2/WebProcess/WebPage/WebInspector.cpp:278:6: warning: unused parameter ‘enabled’ [-Wunused-parameter]
 void WebInspector::setJavaScriptProfilingEnabled(bool enabled)
Comment 1 Radar WebKit Bug Importer 2014-07-21 23:56:38 PDT 
<rdar://problem/17759190>
Comment 2 Shivakumar J M 2014-07-22 01:52:41 PDT 
Created attachment 235276 [details]
patch

Fix unused parameter build warning by removing the parameter name
Comment 3 Build Bot 2014-07-22 08:00:45 PDT 
Comment on attachment 235276 [details]
patch

Attachment 235276 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/4759925733457920

New failing tests:
media/W3C/video/networkState/networkState_during_loadstart.html
Comment 4 Build Bot 2014-07-22 08:00:50 PDT 
Created attachment 235291 [details]
Archive of layout-test-results from webkit-ews-09 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-09  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5
Comment 5 Joseph Pecoraro 2014-07-22 10:42:36 PDT 
Comment on attachment 235276 [details]
patch

r=me
Comment 6 WebKit Commit Bot 2014-07-22 11:14:05 PDT 
Comment on attachment 235276 [details]
patch

Clearing flags on attachment: 235276

Committed r171349: <http://trac.webkit.org/changeset/171349>
Comment 7 WebKit Commit Bot 2014-07-22 11:14:12 PDT 
All reviewed patches have been landed.  Closing bug.