Bug 135137 - build.webkit.org/dashboard: webkitperl failures show up as yellow, not red
Summary: build.webkit.org/dashboard: webkitperl failures show up as yellow, not red
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alexey Proskuryakov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-07-21 17:29 PDT by Alexey Proskuryakov
Modified: 2014-07-21 19:16 PDT (History)
2 users (show)

See Also:


Attachments
proposed fix (11.86 KB, patch)
2014-07-21 17:33 PDT, Alexey Proskuryakov
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2014-07-21 17:29:26 PDT
webkitperl results are boolean, so we can't check failure count. Should do the same thing we do for bindings tests.
Comment 1 Alexey Proskuryakov 2014-07-21 17:33:06 PDT
Created attachment 235258 [details]
proposed fix
Comment 2 WebKit Commit Bot 2014-07-21 19:16:08 PDT
Comment on attachment 235258 [details]
proposed fix

Clearing flags on attachment: 235258

Committed r171333: <http://trac.webkit.org/changeset/171333>
Comment 3 WebKit Commit Bot 2014-07-21 19:16:11 PDT
All reviewed patches have been landed.  Closing bug.