Bug 135136 - Lots of crashes in IOSurfacePool and related places because we use IntSize(0, 0) as a HashTable key
Summary: Lots of crashes in IOSurfacePool and related places because we use IntSize(0,...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2014-07-21 17:27 PDT by Tim Horton
Modified: 2014-07-21 18:26 PDT (History)
3 users (show)

See Also:

Attachments
patch (1.55 KB, patch)
2014-07-21 17:29 PDT, Tim Horton 		simon.fraser: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2014-07-21 17:27:30 PDT 
IntSize(0, 0) as the key to CachedSurfaceMap ends in tears, and there's really no reason to be wasting space on them in the pool - we shouldn't even be allocating them in the first place!

<rdar://problem/17478407>
Comment 1 Tim Horton 2014-07-21 17:29:25 PDT 
Created attachment 235256 [details]
patch
Comment 2 Tim Horton 2014-07-21 18:26:53 PDT 
http://trac.webkit.org/changeset/171332