When I translated the "auto-version.sh" script into Perl, I misunderstood the pattern matching used for the __VERSION_MAJOR__ and __VERSION_MINOR__ components and assumed that version numbers must always be three (or more) digits. In fact, this script was meant to support two-digit versions as well. This patch corrects the regular expression to handle this case.
Created attachment 235224 [details] Patch
<rdar://problem/17743959>
Original Shell code: MAJOR_VERSION=${BUILD_MAJOR_VERSION:0:1} MINOR_VERSION=${BUILD_MAJOR_VERSION:1} Proposed Perl version: $BUILD_MAJOR_VERSION =~ m/^[^\d]*(\d)(\d{1,})/; my $MAJOR_VERSION = $1; my $MINOR_VERSION = $2;
Created attachment 235225 [details] Patch
Created attachment 235226 [details] Patch
Script behavior: 'auto-version.sh': RC_PROJECTSOURCEVERSION=15300 -> 300 -> 3, 00 RC_PROJECTSOURCEVERSION=5300 -> 300 -> 3, 00 RC_PROJECTSOURCEVERSION=530 -> 530 -> 5, 30 RC_PROJECTSOURCEVERSION=53 -> 53 -> 5, 3 RC_PROJECTSOURCEVERSION=5 -> 5 -> 5, ERROR 'auto-version.pl': RC_PROJECTSOURCEVERSION=15300 -> 300 -> 3, 00 RC_PROJECTSOURCEVERSION=5300 -> 300 -> 3, 00 RC_PROJECTSOURCEVERSION=530 -> 530 -> 5, 30 RC_PROJECTSOURCEVERSION=53 -> 53 -> 5, 3 RC_PROJECTSOURCEVERSION=5 -> 5 -> ERROR
Created attachment 235227 [details] Patch
Comment on attachment 235227 [details] Patch r=me
Committed r171305: <http://trac.webkit.org/changeset/171305>