Bug 135102 - Crashes seen in wheel event handling
Summary: Crashes seen in wheel event handling
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: UI Events (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Darin Adler
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2014-07-20 10:39 PDT by Darin Adler
Modified: 2014-07-20 13:12 PDT (History)
3 users (show)

See Also:

Attachments
Patch (9.18 KB, patch)
2014-07-20 10:41 PDT, Darin Adler 		no flags Details | Formatted Diff | Diff
Patch (9.84 KB, patch)
2014-07-20 10:44 PDT, Darin Adler 		bdakin: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Darin Adler 2014-07-20 10:39:38 PDT 
Crashes seen in wheel event handling
Comment 1 Darin Adler 2014-07-20 10:41:40 PDT 
Created attachment 235186 [details]
Patch
Comment 2 Darin Adler 2014-07-20 10:42:28 PDT 
<rdar://problem/17187096>
Comment 3 Darin Adler 2014-07-20 10:44:53 PDT 
Created attachment 235187 [details]
Patch
Comment 4 Darin Adler 2014-07-20 12:56:05 PDT 
Comment on attachment 235187 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=235187&action=review

> Source/WebCore/page/EventHandler.cpp:2578
> +    // Instead, the handlers should know convert vertical scrolls appropriately.

Oops, typo here. Should be "how to convert".
Comment 5 Beth Dakin 2014-07-20 12:57:00 PDT 
Comment on attachment 235187 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=235187&action=review

> Source/WebCore/page/mac/EventHandlerMac.mm:850
> +        // FIXME: I don't understand the lifetime guarantee for this data member.

I think this is a great question, but it feels little oddly phrased as a comment in the context of other WebKit comments. Maybe it's fine, but I think you could also just have:

FIXME: What prevents us from deleting this scrollable container while still holding a pointer to it?
Comment 6 Darin Adler 2014-07-20 13:12:16 PDT 
Committed r171283: <http://trac.webkit.org/changeset/171283>