Bug 135048 – Add --dry-run option to sort-export-file

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Nagy Renátó]

Adding dry-run option to sort-export-file script to simulate run without any file modification.

[Nagy Renátó]

Created attachment 235125 [details]
Proposed patch

The check-webkit-style script is going to need this feature later.

[Tim Horton]

Comment on attachment 235125 [details]
Proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=235125&action=review

> Tools/Scripts/sort-export-file:149
> +            print STDERR "$exportFile should be sorted \n" if $shouldBeVerbose;

I think the return code of the script should indicate whether it was already sorted or not, for ease of use from other scripts.

[Nagy Renátó]

Adding new return code to sort-export-file.

[Nagy Renátó]

Created attachment 235215 [details]
Proposed patch

[Nagy Renátó]

Created attachment 235277 [details]
Proposed patch

[Nagy Renátó]

Created attachment 235278 [details]
Proposed patch

[Csaba Osztrogonác]

Comment on attachment 235278 [details]
Proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=235278&action=review

> Tools/Scripts/sort-export-file:157
>          open OUT, ">", $exportFile or die "Could not overwrite $exportFile: $!";
>          print OUT $after;
>          close OUT;

You shouldn't update the export files here.

[Nagy Renátó]

Created attachment 235509 [details]
Patch

[Nagy Renátó]

Created attachment 235510 [details]
Proposed patch

[Nagy Renátó]

Created attachment 235515 [details]
Proposed patch

[WebKit Commit Bot]

Comment on attachment 235515 [details]
Proposed patch

Clearing flags on attachment: 235515

Committed r171594: <http://trac.webkit.org/changeset/171594>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Darin Adler]

Comment on attachment 235515 [details]
Proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=235515&action=review

> Tools/Scripts/sort-export-file:63
> +       0      if OK
> +
> +       1      if parse error
> +
> +       2      if file(s) should be sorted (only with --dry-run)
> +
> +       3      if parse error and file(s) should be sorted (only with --dry-run)

Too many blank lines!

[Csaba Osztrogonác]

(In reply to comment #13)
> (From update of attachment 235515 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=235515&action=review
> 
> > Tools/Scripts/sort-export-file:63
> > +       0      if OK
> > +
> > +       1      if parse error
> > +
> > +       2      if file(s) should be sorted (only with --dry-run)
> > +
> > +       3      if parse error and file(s) should be sorted (only with --dry-run)
> 
> Too many blank lines!

Followup fix landed in https://trac.webkit.org/changeset/171674