Bug 134914 – [Cocoa] _WKRemoteObjectInterface leaks NSString ivar

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Joseph Pecoraro]

_WKRemoteObjectInterface copies _identifier in initialization, but doesn't have a -dealloc to release it.

<rdar://problem/17672075>

[Joseph Pecoraro]

Created attachment 234895 [details]
[PATCH] Proposed Fix

Alternatively this could be an explicit ivar with RetainPtr.

[Anders Carlsson]

Comment on attachment 234895 [details]
[PATCH] Proposed Fix

Please use a RetainPtr instead.

[WebKit Commit Bot]

Comment on attachment 234895 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 234895

Committed r171098: <http://trac.webkit.org/changeset/171098>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Joseph Pecoraro]

(In reply to comment #2)
> (From update of attachment 234895 [details])
> Please use a RetainPtr instead.

Heh, you should have cq-. I'll follow-up.

[Joseph Pecoraro]

(In reply to comment #5)
> (In reply to comment #2)
> > (From update of attachment 234895 [details] [details])
> > Please use a RetainPtr instead.
> 
> Heh, you should have cq-. I'll follow-up.

Oh, I think there was a review collision and the flags got overwritten.

[Joseph Pecoraro]

(In reply to comment #5)
> (In reply to comment #2)
> > (From update of attachment 234895 [details] [details])
> > Please use a RetainPtr instead.
> 
> Heh, you should have cq-. I'll follow-up.

The identifier property is (as written) atomic, so making an explicit RetainPtr<NSString> ivar and reimplementing the getter atomically seems like unnecessary extra work considering the simplicity of the current patch. Let me know if you feel strongly about this, or perhaps the atomic is unnecessary.

[Anders Carlsson]

(In reply to comment #7)
> (In reply to comment #5)
> > (In reply to comment #2)
> > > (From update of attachment 234895 [details] [details] [details])
> > > Please use a RetainPtr instead.
> > 
> > Heh, you should have cq-. I'll follow-up.
> 
> The identifier property is (as written) atomic, so making an explicit RetainPtr<NSString> ivar and reimplementing the getter atomically seems like unnecessary extra work considering the simplicity of the current patch. Let me know if you feel strongly about this, or perhaps the atomic is unnecessary.

Make it non-atomic instead.