The following API breaks were detected in GObject DOM bindings after Element.scroll* APIs were reverted to type int on r171014 <http://trac.webkit.org/r171014>. $ Tools/gtk/check-for-webkitdom-api-breaks Missing API (API break!) detected in GObject DOM bindings gdouble webkit_dom_element_get_scroll_left(WebKitDOMElement*) void webkit_dom_element_set_scroll_left(WebKitDOMElement*, gdouble) gdouble webkit_dom_element_get_scroll_top(WebKitDOMElement*) gdouble webkit_dom_element_get_scroll_height(WebKitDOMElement*) void webkit_dom_element_set_scroll_top(WebKitDOMElement*, gdouble) gdouble webkit_dom_element_get_scroll_width(WebKitDOMElement*) Re-add the missing API and rerun the ./Tools/gtk/check-for-webkitdom-api-breaks.
Created attachment 234887 [details] Patch
Comment on attachment 234887 [details] Patch Attachment 234887 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/5664178383618048 New failing tests: media/W3C/video/src/src_reflects_attribute_not_source_elements.html
Created attachment 234896 [details] Archive of layout-test-results from webkit-ews-10 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: webkit-ews-10 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5
??? Is impossible that a patch that only touches the file Source/WebCore/bindings/gobject/webkitdom.symbols makes any test on the Mac port fail...... I guess this is just a flaky test. I'm going to re-upload the patch to double check it (just in case)
Created attachment 234899 [details] Patch
Comment on attachment 234899 [details] Patch Attachment 234899 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/5550052512628736 New failing tests: media/media-fragments/TC0001.html
Created attachment 234903 [details] Archive of layout-test-results from webkit-ews-16 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: webkit-ews-16 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5
Comment on attachment 234899 [details] Patch Clearing flags on attachment: 234899 Committed r171103: <http://trac.webkit.org/changeset/171103>
All reviewed patches have been landed. Closing bug.