RESOLVED FIXED 134884
check-webkit-style should apply C++ rules to Objective-C++ files 
https://bugs.webkit.org/show_bug.cgi?id=134884
Summary check-webkit-style should apply C++ rules to Objective-C++ files
Daniel Bates
Reported 2014-07-14 09:08:56 PDT
Currently check-webkit-style considers Objective-C++ files as Objective-C files and hence doesn't apply rules that are applicable to C++ code. We should teach check-webkit-style to apply its C++ rules to Objective-C++ files (if applicable - see remark (*)) to identify Objective-C++ code that doesn't conform to the WebKit Code Style Guidelines. (*) At the time of writing, we allow Objective-C code in an Objective-C++ file to use NULL for a null pointer instead of the C++ idiom nullptr per <http://www.webkit.org/coding/coding-style.html#zero-null>.
Attachments
Patch and unit tests (9.58 KB, patch)
2014-07-14 09:21 PDT, Daniel Bates 		joepeck: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Daniel Bates
Comment 1 2014-07-14 09:21:05 PDT
Created attachment 234856 [details] Patch and unit tests
Joseph Pecoraro
Comment 2 2014-07-14 11:01:33 PDT
Comment on attachment 234856 [details] Patch and unit tests r=me, nice!
Daniel Bates
Comment 3 2014-07-14 15:23:11 PDT
Committed r171088: <http://trac.webkit.org/changeset/171088>
Note You need to log in before you can comment on or make changes to this bug.