Bug 134884 - check-webkit-style should apply C++ rules to Objective-C++ files
Summary: check-webkit-style should apply C++ rules to Objective-C++ files
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Daniel Bates
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-07-14 09:08 PDT by Daniel Bates
Modified: 2014-07-14 15:23 PDT (History)
5 users (show)

See Also:

Attachments
Patch and unit tests (9.58 KB, patch)
2014-07-14 09:21 PDT, Daniel Bates 		joepeck: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Bates 2014-07-14 09:08:56 PDT 
Currently check-webkit-style considers Objective-C++ files as Objective-C files and hence doesn't apply rules that are applicable to C++ code. We should teach check-webkit-style to apply its C++ rules to Objective-C++ files (if applicable - see remark (*)) to identify Objective-C++ code that doesn't conform to the WebKit Code Style Guidelines.

(*) At the time of writing, we allow Objective-C code in an Objective-C++ file to use NULL for a null pointer instead of the C++ idiom nullptr per <http://www.webkit.org/coding/coding-style.html#zero-null>.
Comment 1 Daniel Bates 2014-07-14 09:21:05 PDT 
Created attachment 234856 [details]
Patch and unit tests
Comment 2 Joseph Pecoraro 2014-07-14 11:01:33 PDT 
Comment on attachment 234856 [details]
Patch and unit tests

r=me, nice!
Comment 3 Daniel Bates 2014-07-14 15:23:11 PDT 
Committed r171088: <http://trac.webkit.org/changeset/171088>