Bug 134864 - Move composite bounds calculation to RenderLayerBacking.
Summary: Move composite bounds calculation to RenderLayerBacking.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-07-12 18:57 PDT by zalan
Modified: 2014-07-14 12:15 PDT (History)
7 users (show)

See Also:


Attachments
Patch (4.10 KB, patch)
2014-07-12 19:04 PDT, zalan
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from webkit-ews-13 for mac-mountainlion-wk2 (502.56 KB, application/zip)
2014-07-12 21:09 PDT, Build Bot
no flags Details
Archive of layout-test-results from webkit-ews-16 for mac-mountainlion-wk2 (527.14 KB, application/zip)
2014-07-12 22:13 PDT, Build Bot
no flags Details
Patch (4.14 KB, patch)
2014-07-14 10:27 PDT, zalan
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2014-07-12 18:57:16 PDT
for better functionality encapsulation.
Comment 1 zalan 2014-07-12 19:03:25 PDT
RenderLayerCompositor was just proxying the calculateLayerBounds() to the RenderLayer.
Comment 2 zalan 2014-07-12 19:04:17 PDT
Created attachment 234820 [details]
Patch
Comment 3 Darin Adler 2014-07-12 19:11:12 PDT
Comment on attachment 234820 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=234820&action=review

> Source/WebCore/rendering/RenderLayerCompositor.cpp:-976
> -    if (!canBeComposited(layer))
> -        return LayoutRect();

The patch deletes this check. Why isn’t this needed?
Comment 4 zalan 2014-07-12 19:21:07 PDT
(In reply to comment #3)
> (From update of attachment 234820 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=234820&action=review
> 
> > Source/WebCore/rendering/RenderLayerCompositor.cpp:-976
> > -    if (!canBeComposited(layer))
> > -        return LayoutRect();
> 
> The patch deletes this check. Why isn’t this needed?
the m_owningLayer of the RenderLayerBackig is always composited so that check should always evaluate to true, but I'll check with smfr before landing.
Comment 5 Build Bot 2014-07-12 21:09:09 PDT
Comment on attachment 234820 [details]
Patch

Attachment 234820 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/6458563052437504

New failing tests:
media/W3C/video/networkState/networkState_during_loadstart.html
Comment 6 Build Bot 2014-07-12 21:09:12 PDT
Created attachment 234822 [details]
Archive of layout-test-results from webkit-ews-13 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-13  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5
Comment 7 zalan 2014-07-12 21:09:47 PDT
(In reply to comment #5)
> (From update of attachment 234820 [details])
> Attachment 234820 [details] did not pass mac-wk2-ews (mac-wk2):
> Output: http://webkit-queues.appspot.com/results/6458563052437504
> 
> New failing tests:
> media/W3C/video/networkState/networkState_during_loadstart.html

seems unrelated.
Comment 8 Build Bot 2014-07-12 22:13:54 PDT
Comment on attachment 234820 [details]
Patch

Attachment 234820 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/6541610808508416

New failing tests:
media/W3C/video/networkState/networkState_during_loadstart.html
Comment 9 Build Bot 2014-07-12 22:13:58 PDT
Created attachment 234825 [details]
Archive of layout-test-results from webkit-ews-16 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-16  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5
Comment 10 zalan 2014-07-14 10:27:59 PDT
Created attachment 234864 [details]
Patch
Comment 11 zalan 2014-07-14 10:28:19 PDT
Comment on attachment 234864 [details]
Patch

EWS testing
Comment 12 WebKit Commit Bot 2014-07-14 12:15:48 PDT
Comment on attachment 234864 [details]
Patch

Clearing flags on attachment: 234864

Committed r171073: <http://trac.webkit.org/changeset/171073>
Comment 13 WebKit Commit Bot 2014-07-14 12:15:52 PDT
All reviewed patches have been landed.  Closing bug.