WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
134856
[iOS] update control type when playback state changes
https://bugs.webkit.org/show_bug.cgi?id=134856
Summary
[iOS] update control type when playback state changes
Eric Carlson
Reported
2014-07-12 11:16:34 PDT
The iOS media controls potentially have two modes: a big play button that sits in the middle of the <video> and inline controls. On devices that allow inline playback, the big play button is always shown and the inline controller is supposed to show once playback begins. Currently the control type is only checked/changed when readyState changes, so it is possible to get stuck with the overlay button if readyState reaches loadeddata before playback begins.
Attachments
Proposed patch
(2.36 KB, patch)
2014-07-12 11:42 PDT
,
Eric Carlson
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Eric Carlson
Comment 1
2014-07-12 11:42:01 PDT
Created
attachment 234805
[details]
Proposed patch I wasn't able to come up with a reliable test because the problem this patch fixes is extremely timing dependent.
WebKit Commit Bot
Comment 2
2014-07-12 15:15:06 PDT
Comment on
attachment 234805
[details]
Proposed patch Clearing flags on attachment: 234805 Committed
r171032
: <
http://trac.webkit.org/changeset/171032
>
WebKit Commit Bot
Comment 3
2014-07-12 15:15:09 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug