Bug 134856 - [iOS] update control type when playback state changes
Summary: [iOS] update control type when playback state changes
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-07-12 11:16 PDT by Eric Carlson
Modified: 2014-07-12 15:15 PDT (History)
7 users (show)

See Also:

Attachments
Proposed patch (2.36 KB, patch)
2014-07-12 11:42 PDT, Eric Carlson 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Carlson 2014-07-12 11:16:34 PDT 
The iOS media controls potentially have two modes: a big play button that sits in the middle of the <video> and inline controls. On devices that allow inline playback, the big play button is always shown and the inline controller is supposed to show once playback begins. 

Currently the control type is only checked/changed when readyState changes, so it is possible to get stuck with the overlay button if readyState reaches loadeddata before playback begins.
Comment 1 Eric Carlson 2014-07-12 11:42:01 PDT 
Created attachment 234805 [details]
Proposed patch

I wasn't able to come up with a reliable test because the problem this patch fixes is extremely timing dependent.
Comment 2 WebKit Commit Bot 2014-07-12 15:15:06 PDT 
Comment on attachment 234805 [details]
Proposed patch

Clearing flags on attachment: 234805

Committed r171032: <http://trac.webkit.org/changeset/171032>
Comment 3 WebKit Commit Bot 2014-07-12 15:15:09 PDT 
All reviewed patches have been landed.  Closing bug.