Bug 134852 - [MSE] http/tests/media/media-source/mediasource-duration.html is failing.
Summary: [MSE] http/tests/media/media-source/mediasource-duration.html is failing.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jer Noble
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-07-11 23:25 PDT by Jer Noble
Modified: 2014-07-16 08:52 PDT (History)
17 users (show)

See Also:

Attachments
Patch (213.44 KB, patch)
2014-07-12 00:15 PDT, Jer Noble 		no flags Details | Formatted Diff | Diff
Patch (217.62 KB, patch)
2014-07-12 08:16 PDT, Jer Noble 		no flags Details | Formatted Diff | Diff
Patch (61.21 KB, patch)
2014-07-12 08:21 PDT, Jer Noble 		no flags Details | Formatted Diff | Diff
Patch (217.69 KB, patch)
2014-07-12 08:26 PDT, Jer Noble 		no flags Details | Formatted Diff | Diff
Patch (217.61 KB, patch)
2014-07-12 08:33 PDT, Jer Noble 		eric.carlson: review+
Details | Formatted Diff | Diff
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jer Noble 2014-07-11 23:25:33 PDT 
[MSE] http/tests/media/media-source/mediasource-duration.html is failing.
Comment 1 Jer Noble 2014-07-12 00:15:31 PDT 
Created attachment 234796 [details]
Patch
Comment 2 WebKit Commit Bot 2014-07-12 00:17:21 PDT 
Attachment 234796 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:154:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Total errors found: 1 in 20 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Jer Noble 2014-07-12 08:16:04 PDT 
Created attachment 234800 [details]
Patch
Comment 4 Jer Noble 2014-07-12 08:16:42 PDT 
Fixed the gtk-wk2 EWS.
Comment 5 WebKit Commit Bot 2014-07-12 08:16:59 PDT 
Attachment 234800 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:154:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Total errors found: 1 in 22 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 6 Jer Noble 2014-07-12 08:21:14 PDT 
Created attachment 234801 [details]
Patch
Comment 7 WebKit Commit Bot 2014-07-12 08:23:50 PDT 
Attachment 234801 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:154:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Total errors found: 1 in 21 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 8 Jer Noble 2014-07-12 08:26:56 PDT 
Created attachment 234802 [details]
Patch
Comment 9 WebKit Commit Bot 2014-07-12 08:28:28 PDT 
Attachment 234802 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:154:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Total errors found: 1 in 22 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 10 Jer Noble 2014-07-12 08:33:33 PDT 
Created attachment 234803 [details]
Patch
Comment 11 WebKit Commit Bot 2014-07-12 08:35:20 PDT 
Attachment 234803 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:154:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Total errors found: 1 in 22 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 12 Eric Carlson 2014-07-12 09:19:48 PDT 
Comment on attachment 234803 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=234803&action=review

> Source/WebCore/ChangeLog:131
> +        (WebCore::HTMLMediaElement::parseAttribute): Do not issue an additional 'timeupdate' event
> +            after finishSeek() issues one of its own.

svn-create-patch fail: parseAttribute -> mediaPlayerTimeChanged
Comment 13 Jer Noble 2014-07-12 15:40:36 PDT 
Committed r171033: <http://trac.webkit.org/changeset/171033>
Comment 14 Carlos Alberto Lopez Perez 2014-07-16 08:52:33 PDT 
This has caused the tests media/media-controls-invalid-url.html and media/video-fast-seek.html fail on the GTK port.

Reported here: https://bugs.webkit.org/show_bug.cgi?id=134976