Bug 134752 - Get rid of WebFontCache
Summary: Get rid of WebFontCache
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Myles C. Maxfield
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2014-07-08 22:08 PDT by Myles C. Maxfield
Modified: 2014-11-14 16:03 PST (History)
9 users (show)

See Also:

Attachments
Patch (34.02 KB, patch)
2014-07-23 14:24 PDT, Myles C. Maxfield 		no flags Details | Formatted Diff | Diff
Patch (44.54 KB, patch)
2014-11-14 15:49 PST, Myles C. Maxfield 		hyatt: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Myles C. Maxfield 2014-07-08 22:08:34 PDT 
No reason it should be around
Comment 1 Myles C. Maxfield 2014-07-23 14:24:05 PDT 
Created attachment 235378 [details]
Patch
Comment 2 WebKit Commit Bot 2014-07-23 14:25:16 PDT 
Attachment 235378 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/graphics/mac/FontCacheMac.mm:32:  Found header this file implements after a header this file implements. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
Total errors found: 1 in 7 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Myles C. Maxfield 2014-07-23 14:27:47 PDT 
Style is a false negative.
Comment 4 mitz 2014-11-11 15:18:23 PST 
Comment on attachment 235378 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=235378&action=review

> Source/WebCore/platform/graphics/mac/FontCacheMac.mm:213
> +#pragma clang diagnostic ignored "-Wglobal-constructors"

WebCore is not allowed to include global constructors, which is why we have enabled this warning.
Comment 5 Radar WebKit Bug Importer 2014-11-11 15:18:56 PST 
<rdar://problem/18947048>
Comment 6 Myles C. Maxfield 2014-11-14 15:49:18 PST 
Created attachment 241635 [details]
Patch
Comment 7 Dave Hyatt 2014-11-14 15:57:19 PST 
Comment on attachment 241635 [details]
Patch

r=me
Comment 8 Myles C. Maxfield 2014-11-14 16:03:31 PST 
https://trac.webkit.org/r176146