Bug 134741 – Revert r170413 and r170390

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Myles C. Maxfield]

Revert r170413 and r170390

[Myles C. Maxfield]

Created attachment 234585 [details]
Patch

[WebKit Commit Bot]

Attachment 234585 [details] did not pass style-queue:


ERROR: Source/WebCore/rendering/svg/SVGTextRunRenderingContext.cpp:106:  The parameter name "const" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 1 in 37 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[alan]

is there a list somewhere with the sites/use cases that the original changeset broke?

[Benjamin Poulain]

Comment on attachment 234585 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=234585&action=review

> Source/WebCore/rendering/InlineTextBox.cpp:1409
> +TextRun InlineTextBox::constructTextRun(const RenderStyle& style, const Font& font, String string, int maximumLength, String* hyphenatedStringBuffer) const
>  {
> -    unsigned length = string.length();
> +    int length = string.length();

This is suspicious, can you explain this?

[Jon Lee]

<rdar://problem/17571191>

[Build Bot]

Comment on attachment 234585 [details]
Patch

Attachment 234585 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/6450686417960960

New failing tests:
media/W3C/video/src/src_reflects_attribute_not_source_elements.html

[Build Bot]

Created attachment 234599 [details]
Archive of layout-test-results from webkit-ews-10 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-10  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5

[Myles C. Maxfield]

Created attachment 234640 [details]
Patch

[WebKit Commit Bot]

Attachment 234640 [details] did not pass style-queue:


ERROR: Source/WebCore/rendering/svg/SVGTextRunRenderingContext.cpp:106:  The parameter name "const" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 1 in 37 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Myles C. Maxfield]

looks like efl-wk2 was a false negative

[WebKit Commit Bot]

Comment on attachment 234640 [details]
Patch

Clearing flags on attachment: 234640

Committed r170947: <http://trac.webkit.org/changeset/170947>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.