Bug 134572 - REGRESSION(WK2): Undo does not work in text fields in Safari
Summary: REGRESSION(WK2): Undo does not work in text fields in Safari
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: iPhone / iPad Unspecified
: P2 Normal
Assignee: Enrica Casucci
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2014-07-02 17:38 PDT by Enrica Casucci
Modified: 2014-07-02 18:00 PDT (History)
5 users (show)

See Also:

Attachments
Patch (5.23 KB, patch)
2014-07-02 17:42 PDT, Enrica Casucci 		benjamin: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Enrica Casucci 2014-07-02 17:38:23 PDT 
<rdar://problem/17542238>
Comment 1 Enrica Casucci 2014-07-02 17:42:12 PDT 
Created attachment 234300 [details]
Patch
Comment 2 WebKit Commit Bot 2014-07-02 17:45:15 PDT 
Attachment 234300 [details] did not pass style-queue:


ERROR: Source/WebKit2/UIProcess/ios/PageClientImplIOS.mm:65:  This { should be at the end of the previous line  [whitespace/braces] [4]
Total errors found: 1 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Benjamin Poulain 2014-07-02 17:57:10 PDT 
Comment on attachment 234300 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=234300&action=review

Looks reasonable.

> Source/WebKit2/UIProcess/ios/PageClientImplIOS.mm:89
> +- (WebEditCommandProxy*)command

Space before the star.
Comment 4 Enrica Casucci 2014-07-02 18:00:04 PDT 
Committed revision 170738.