Add a encodeLegacySessionState function

[Anders Carlsson]

Add a encodeLegacySessionState function

[Anders Carlsson]

Created attachment 234180 [details]
Patch

[WebKit Commit Bot]

Attachment 234180 [details] did not pass style-queue:


ERROR: Source/WebKit2/UIProcess/mac/LegacySessionStateCoding.cpp:408:  One line control clauses should not use braces.  [whitespace/braces] [4]
Total errors found: 1 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Tim Horton]

Comment on attachment 234180 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=234180&action=review

> Source/WebKit2/UIProcess/mac/LegacySessionStateCoding.cpp:406
> +    if (!backForwardListState.currentIndex) {

don't think you want the braces here

> Source/WebKit2/UIProcess/mac/LegacySessionStateCoding.cpp:460
> +    buffer.get()[2] = (sessionStateDataVersion & 0x0000ff0) >> 8;

this doesn't look right! should be 0x0000ff00, no?

[Enrica Casucci]

Comment on attachment 234180 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=234180&action=review

> Source/WebKit2/UIProcess/mac/LegacySessionStateCoding.cpp:380
> +

unnecessary empty line.

> Source/WebKit2/UIProcess/mac/LegacySessionStateCoding.cpp:407
> +        return createDictionary({ { sessionHistoryVersionKey, sessionHistoryVersionNumber.get() } });

Probably don't need braces here.

[Enrica Casucci]

Comment on attachment 234180 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=234180&action=review

> Source/WebKit2/UIProcess/mac/LegacySessionStateCoding.cpp:380
> +

unnecessary empty line.

> Source/WebKit2/UIProcess/mac/LegacySessionStateCoding.cpp:407
> +        return createDictionary({ { sessionHistoryVersionKey, sessionHistoryVersionNumber.get() } });

Probably don't need braces here.

[Anders Carlsson]

Committed r170654: <http://trac.webkit.org/changeset/170654>