Bug 134453 - Add encodeInteger and decodeInteger for remote object encoder and decoder.
Summary: Add encodeInteger and decodeInteger for remote object encoder and decoder.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-06-30 14:02 PDT by Yongjun Zhang
Modified: 2014-07-01 10:15 PDT (History)
8 users (show)

See Also:


Attachments
Patch. (2.90 KB, patch)
2014-06-30 14:08 PDT, Yongjun Zhang
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Yongjun Zhang 2014-06-30 14:02:06 PDT
In 64bit system, encodeInteger/decodeInteger is by default mapped into encodeInt64/decodeInt64.  For 32bit system, they are mapped to encodeInt32/decodeInt32.  However, since we don't have encodeInt32/decodeInt32 implementation in WKRemoteObjectCoder, we could hit crash in 32bit systems.
Comment 1 Yongjun Zhang 2014-06-30 14:08:51 PDT
Created attachment 234091 [details]
Patch.
Comment 2 Yongjun Zhang 2014-06-30 14:14:51 PDT
<rdar://problem/16964074>
Comment 3 WebKit Commit Bot 2014-07-01 10:15:01 PDT
Comment on attachment 234091 [details]
Patch.

Clearing flags on attachment: 234091

Committed r170645: <http://trac.webkit.org/changeset/170645>
Comment 4 WebKit Commit Bot 2014-07-01 10:15:05 PDT
All reviewed patches have been landed.  Closing bug.