Bug 134445 - Remove Qt cruft from webkitpy
Summary: Remove Qt cruft from webkitpy
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-06-30 06:41 PDT by Tibor Mészáros
Modified: 2014-06-30 07:46 PDT (History)
7 users (show)

See Also:


Attachments
Patch (4.59 KB, patch)
2014-06-30 06:44 PDT, Tibor Mészáros
ossy: review+
ossy: commit-queue-
Details | Formatted Diff | Diff
Patch v2 (4.69 KB, patch)
2014-06-30 07:00 PDT, Tibor Mészáros
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tibor Mészáros 2014-06-30 06:41:09 PDT
There are some Qt crufts in Tools/Scripts/webkitpy/common/config/ports.py and its unit test. We should remove them.
Comment 1 Tibor Mészáros 2014-06-30 06:44:04 PDT
Created attachment 234074 [details]
Patch

This patch will remove Qt cruft from webkitpy
Comment 2 Csaba Osztrogonác 2014-06-30 06:50:32 PDT
Comment on attachment 234074 [details]
Patch

WOW, Qt is still exist here. :) LGTM, but please update your patch to ToT.
Comment 3 Tibor Mészáros 2014-06-30 07:00:53 PDT
Created attachment 234076 [details]
Patch v2

Updated patch
Comment 4 WebKit Commit Bot 2014-06-30 07:46:14 PDT
Comment on attachment 234076 [details]
Patch v2

Clearing flags on attachment: 234076

Committed r170582: <http://trac.webkit.org/changeset/170582>
Comment 5 WebKit Commit Bot 2014-06-30 07:46:18 PDT
All reviewed patches have been landed.  Closing bug.