Bug 134415 - ScrollView::rootViewToTotalContents() needs to take topContentInset into account
Summary: ScrollView::rootViewToTotalContents() needs to take topContentInset into account
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2014-06-27 15:06 PDT by Beth Dakin
Modified: 2014-06-27 15:13 PDT (History)
9 users (show)

See Also:


Attachments
Patch (1.47 KB, patch)
2014-06-27 15:08 PDT, Beth Dakin
simon.fraser: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Beth Dakin 2014-06-27 15:06:05 PDT
Much like the other coordinate conversation functions, ScrollView::rootViewToTotalContents() needs to take topContentInset into account.

<rdar://problem/17473633>
Comment 1 Beth Dakin 2014-06-27 15:08:20 PDT
Created attachment 234022 [details]
Patch
Comment 2 Simon Fraser (smfr) 2014-06-27 15:10:53 PDT
Comment on attachment 234022 [details]
Patch

Maybe say what the visible impact of this was?
Comment 3 Beth Dakin 2014-06-27 15:13:36 PDT
(In reply to comment #2)
> (From update of attachment 234022 [details])
> Maybe say what the visible impact of this was?

Thanks! I added a line to the changelog about that.

http://trac.webkit.org/changeset/170558