WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
134369
Remove unnecessary #include in HistoryController
https://bugs.webkit.org/show_bug.cgi?id=134369
Summary
Remove unnecessary #include in HistoryController
Sungmann Cho
Reported
2014-06-26 16:52:31 PDT
After the landing of
https://webkit.org/b/130099
, HistoryController doesn't need WebCore::Settings class. So we can remove the related header.
Attachments
Patch
(1.02 KB, patch)
2014-06-26 16:58 PDT
,
Sungmann Cho
no flags
Details
Formatted Diff
Diff
Patch
(1.16 KB, patch)
2014-06-26 17:03 PDT
,
Sungmann Cho
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Sungmann Cho
Comment 1
2014-06-26 16:58:40 PDT
Created
attachment 233947
[details]
Patch
Sungmann Cho
Comment 2
2014-06-26 17:03:35 PDT
Created
attachment 233948
[details]
Patch
Daniel Bates
Comment 3
2014-06-26 21:48:08 PDT
Comment on
attachment 233948
[details]
Patch r=me
WebKit Commit Bot
Comment 4
2014-06-27 00:19:25 PDT
Comment on
attachment 233948
[details]
Patch Clearing flags on attachment: 233948 Committed
r170523
: <
http://trac.webkit.org/changeset/170523
>
WebKit Commit Bot
Comment 5
2014-06-27 00:19:29 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug