Bug 134349 - [MSE] Refactoring: Differentiate between SampleMap decode and presentation order methods
Summary: [MSE] Refactoring: Differentiate between SampleMap decode and presentation or...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jer Noble
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-06-26 10:26 PDT by Jer Noble
Modified: 2014-06-27 00:29 PDT (History)
11 users (show)

See Also:

Attachments
Patch (31.73 KB, patch)
2014-06-26 10:45 PDT, Jer Noble 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jer Noble 2014-06-26 10:26:31 PDT 
[MSE] Refactoring: Differentiate between SampleMap decode and presentation order methods
Comment 1 Jer Noble 2014-06-26 10:45:03 PDT 
Created attachment 233913 [details]
Patch
Comment 2 WebKit Commit Bot 2014-06-26 10:46:19 PDT 
Attachment 233913 [details] did not pass style-queue:


ERROR: Source/WebCore/Modules/mediasource/SampleMap.h:69:  reverse_iterator is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Total errors found: 1 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Geoffrey Garen 2014-06-26 10:48:03 PDT 
Comment on attachment 233913 [details]
Patch

r=me
Comment 4 Jer Noble 2014-06-26 11:17:59 PDT 
Comment on attachment 233913 [details]
Patch

Clearing flags on attachment: 233913

Committed r170484: <http://trac.webkit.org/changeset/170484>
Comment 5 Jer Noble 2014-06-26 11:18:05 PDT 
All reviewed patches have been landed.  Closing bug.