Bug 134312 – remove pointer lock prefixes

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Alex Christensen]

The pointer lock code has webkit prefixes.  If we enable it, we will not want to have prefixes.

[Alex Christensen]

Created attachment 233845 [details]
Patch

[Brady Eidson]

1 - Does any other platform enable PointerLock?

2 - If so, have they shipped with the prefixes?

3 - If so, do they need the prefixes to stay?

You might need to explore the answers to #2 and #3 on webkit-dev

[Alex Christensen]

Chrome hasn't shipped an unprefixed version yet, but it's been in their codebase since https://src.chromium.org/viewvc/blink?revision=173766&view=revision

[Brady Eidson]

(In reply to comment #3)
> Chrome hasn't shipped an unprefixed version yet, but it's been in their codebase since https://src.chromium.org/viewvc/blink?revision=173766&view=revision

I'm not talking about other browsers/engines - I'm talking about other ports of WebKit.  Here, in this project.

[Alex Christensen]

(In reply to comment #4)
> I'm not talking about other browsers/engines - I'm talking about other ports of WebKit.  Here, in this project.
I know.  I just thought I'd add the relevant information.  I'm pretty sure they're the only ones who ever shipped the webkit-prefixed pointer lock and they're no longer in trunk, so let's put this in next week unless someone opposes with a valid reason.

[Dean Jackson]

Comment on attachment 233845 [details]
Patch

No one has complained yet. I guess wait for another day and then go ahead.

[WebKit Commit Bot]

Comment on attachment 233845 [details]
Patch

Clearing flags on attachment: 233845

Committed r170585: <http://trac.webkit.org/changeset/170585>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.