Bug 134270 – [Fullscreen][Mac] WKView is not firstResponder after entering fullscreen mode

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Jer Noble]

[Fullscreen][Mac] WKView is not firstResponder after entering fullscreen mode

[Jer Noble]

Created attachment 233745 [details]
Patch

[Jon Honeycutt]

Comment on attachment 233745 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=233745&action=review

r=me

> Source/WebCore/ChangeLog:10
> +        the window's view heirarchy after the style changes, reset it to the firstResponder.

hierarchy

> Source/WebCore/platform/mac/WebCoreFullScreenWindow.mm:81
> +- (void)setStyleMask:(NSUInteger)styleMask
> +{
> +    NSResponder* savedFirstResponder = [self firstResponder];
> +
> +    [super setStyleMask:styleMask];
> +
> +    if ([self firstResponder] != savedFirstResponder
> +        && [savedFirstResponder isKindOfClass:[NSView class]]
> +        && [(NSView*)savedFirstResponder isDescendantOf:[self contentView]])
> +        [self makeFirstResponder:savedFirstResponder];
> +}

This would benefit from an inline comment explaining why it's done.

[Jer Noble]

<rdar://problem/17043094>

[Jer Noble]

Committed r170397: <http://trac.webkit.org/changeset/170397>