Bug 134215 - Policy delegate methods should use CompletionHandlerCallChecker
Summary: Policy delegate methods should use CompletionHandlerCallChecker
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-06-23 14:38 PDT by Anders Carlsson
Modified: 2014-06-23 14:40 PDT (History)
1 user (show)

See Also:

Attachments
Patch (3.06 KB, patch)
2014-06-23 14:38 PDT, Anders Carlsson 		mitz: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2014-06-23 14:38:16 PDT 
Policy delegate methods should use CompletionHandlerCallChecker
Comment 1 Anders Carlsson 2014-06-23 14:38:57 PDT 
Created attachment 233637 [details]
Patch
Comment 2 WebKit Commit Bot 2014-06-23 14:40:23 PDT 
Attachment 233637 [details] did not pass style-queue:


ERROR: Source/WebKit2/UIProcess/Cocoa/NavigationState.mm:309:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/WebKit2/UIProcess/Cocoa/NavigationState.mm:371:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Total errors found: 2 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Anders Carlsson 2014-06-23 14:40:30 PDT 
Committed r170322: <http://trac.webkit.org/changeset/170322>