Bug 134196 - REGRESSION (r160908): Unable to unset bold while entering text
Summary: REGRESSION (r160908): Unable to unset bold while entering text
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2014-06-23 09:44 PDT by Antti Koivisto
Modified: 2014-06-23 10:03 PDT (History)
1 user (show)

See Also:


Attachments
patch (6.27 KB, patch)
2014-06-23 09:51 PDT, Antti Koivisto
kling: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Antti Koivisto 2014-06-23 09:44:27 PDT
...with some wk1 clients.
Comment 1 Antti Koivisto 2014-06-23 09:44:58 PDT
<rdar://problem/17051653>
Comment 2 Antti Koivisto 2014-06-23 09:51:43 PDT
Created attachment 233612 [details]
patch
Comment 3 Andreas Kling 2014-06-23 09:57:27 PDT
Comment on attachment 233612 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=233612&action=review

r=me bro. Another lazy style regression down!

> Source/WebCore/editing/Editor.h:493
> +    static RenderStyle* styleForSelectionStart(Frame* , Node *&nodeToRemove);

Disturbing * and & placements here.
Comment 4 Antti Koivisto 2014-06-23 10:03:20 PDT
https://trac.webkit.org/r170296