Bug 134001 - Web Inspector: PrettyPrinting regression on "var a=1"
Summary: Web Inspector: PrettyPrinting regression on "var a=1"
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Joseph Pecoraro
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2014-06-17 16:05 PDT by Joseph Pecoraro
Modified: 2014-06-17 17:29 PDT (History)
5 users (show)

See Also:


Attachments
[PATCH] Proposed Fix (3.36 KB, patch)
2014-06-17 16:26 PDT, Joseph Pecoraro
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2014-06-17 16:05:30 PDT
“var a=1;” prettyprints to “var a= 1;” but should pretty print to “var a = 1;”
Comment 1 Radar WebKit Bug Importer 2014-06-17 16:07:48 PDT
<rdar://problem/17350819>
Comment 2 Joseph Pecoraro 2014-06-17 16:08:31 PDT
Seems like shouldHaveSpaceBeforeToken is checking for operators, but assumes operators don't have a token, but maybe they do now, with the token name "operator".
Comment 3 Joseph Pecoraro 2014-06-17 16:26:30 PDT
Created attachment 233268 [details]
[PATCH] Proposed Fix

Makes JavaScript Pretty Printing tests pass in my checkout.
Comment 4 WebKit Commit Bot 2014-06-17 17:29:20 PDT
Comment on attachment 233268 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 233268

Committed r170088: <http://trac.webkit.org/changeset/170088>
Comment 5 WebKit Commit Bot 2014-06-17 17:29:22 PDT
All reviewed patches have been landed.  Closing bug.