Bug 133965 – Web Inspector: style declaration editor: visual highlight doesn't match actual selected text

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Jonathan Wells]

<rdar://problem/17260272>

[Jonathan Wells]

Regression due to CodeMirror 4 changes in tag structure.

[Jonathan Wells]

Created attachment 233209 [details]
[PATCH] Attempted CSS fix

Note, this fix removes the two-character indentation for rules that wrap to a second line or more. The use of the hanging indent hack was causing this and some other problems. `text-indent: hanging`, or something similar, if implemented, might help. With this fix though the highlight doesn't cover the checkboxes which actually makes sense and creates a very clear visual of what the user is selecting.

[Jonathan Wells]

Created attachment 233211 [details]
[PATCH] Attempted CSS fix, remembered ChangeLog

[Joseph Pecoraro]

Comment on attachment 233211 [details]
[PATCH] Attempted CSS fix, remembered ChangeLog

View in context: https://bugs.webkit.org/attachment.cgi?id=233211&action=review

> Source/WebInspectorUI/UserInterface/Views/CSSStyleDeclarationTextEditor.css:43
> +    text-indent: 0;

Can this just be removed? Or is it overriding something?

> Source/WebInspectorUI/UserInterface/Views/CSSStyleDeclarationTextEditor.css:57
>      /* Compensate for the missing checkboxes so properties line up with editable styles that have checkboxes. */
> -    text-indent: -14px;
> +    text-indent: 0;

Can this just all be removed? Or is it overriding something?

[Jonathan Wells]

Created attachment 233257 [details]
[PATCH] Attempted CSS fix, remembered ChangeLog VER 2

[Joseph Pecoraro]

Comment on attachment 233257 [details]
[PATCH] Attempted CSS fix, remembered ChangeLog VER 2

View in context: https://bugs.webkit.org/attachment.cgi?id=233257&action=review

r=me

> Source/WebInspectorUI/UserInterface/Views/CSSStyleDeclarationTextEditor.css:55
>      /* Compensate for the missing checkboxes so properties line up with editable styles that have checkboxes. */

Can this comment be removed now? Essentially we are just removing the indent. In fact the comment may be more useful up above where we do set a text-indent.

[Jonathan Wells]

Created attachment 233262 [details]
[PATCH] Attempted CSS fix, remembered ChangeLog VER 3

[WebKit Commit Bot]

Comment on attachment 233262 [details]
[PATCH] Attempted CSS fix, remembered ChangeLog VER 3

Rejecting attachment 233262 [details] from review queue.

[e-mail] does not have reviewer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/contributors.json.

- If you do not have reviewer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.

- If you have reviewer rights please correct the error in Tools/Scripts/webkitpy/common/config/contributors.json by adding yourself to the file (no review needed).  The commit-queue restarts itself every 2 hours.  After restart the commit-queue will correctly respect your reviewer rights.

[WebKit Commit Bot]

Comment on attachment 233262 [details]
[PATCH] Attempted CSS fix, remembered ChangeLog VER 3

Rejecting attachment 233262 [details] from commit-queue.

[e-mail] does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/contributors.json.

- If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.

- If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/contributors.json by adding yourself to the file (no review needed).  The commit-queue restarts itself every 2 hours.  After restart the commit-queue will correctly respect your committer rights.

[WebKit Commit Bot]

Comment on attachment 233262 [details]
[PATCH] Attempted CSS fix, remembered ChangeLog VER 3

Rejecting attachment 233262 [details] from commit-queue.

[e-mail] does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/contributors.json.

- If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.

- If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/contributors.json by adding yourself to the file (no review needed).  The commit-queue restarts itself every 2 hours.  After restart the commit-queue will correctly respect your committer rights.

[WebKit Commit Bot]

Comment on attachment 233262 [details]
[PATCH] Attempted CSS fix, remembered ChangeLog VER 3

Clearing flags on attachment: 233262

Committed r170077: <http://trac.webkit.org/changeset/170077>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.