Bug 133960 - WebVideoFullscreenInterfaceAVKit could use a session object to implicitly clean up between fullscreen sessions.
Summary: WebVideoFullscreenInterfaceAVKit could use a session object to implicitly cle...
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: 528+ (Nightly build)
Hardware: iPhone / iPad Unspecified
: P2 Normal
Assignee: Jeremy Jones
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-06-16 16:52 PDT by Jeremy Jones
Modified: 2014-06-16 16:52 PDT (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jeremy Jones 2014-06-16 16:52:47 PDT 
> > Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm:792
> > +        [m_window setHidden:YES];
> > +        [m_window setRootViewController:nil];
> > +        [m_playerViewController setDelegate:nil];
> > +        [m_playerViewController setPlayerController:nil];
> > +        m_playerViewController = nil;
> > +        m_viewController = nil;
> > +        m_window = nil;
> > +        [m_videoLayer removeFromSuperlayer];
> > +        m_videoLayer = nil;
> > +        [m_videoLayerContainer removeFromSuperlayer];
> > +        [m_videoLayerContainer setPlayerViewController:nil];
> > +        m_videoLayerContainer = nil;
> 
> So much stuff.

Maybe use a session object