Bug 133922 - Replace StringImpl* callback parameters with const String&
Summary: Replace StringImpl* callback parameters with const String&
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: mitz
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-06-14 18:25 PDT by mitz
Modified: 2014-06-14 19:11 PDT (History)
2 users (show)

See Also:

Attachments
Use const String& in callbacks (9.18 KB, patch)
2014-06-14 18:28 PDT, mitz 		sam: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description mitz 2014-06-14 18:25:14 PDT 
Some callbacks have StringImpl* parameters.
Comment 1 mitz 2014-06-14 18:28:02 PDT 
Created attachment 233132 [details]
Use const String& in callbacks
Comment 2 WebKit Commit Bot 2014-06-14 18:29:17 PDT 
Attachment 233132 [details] did not pass style-queue:


ERROR: Source/WebKit2/UIProcess/API/C/WKPage.cpp:1584:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/WebKit2/UIProcess/API/C/WKPage.cpp:1584:  Extra space before [  [whitespace/braces] [5]
Total errors found: 2 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 mitz 2014-06-14 19:11:15 PDT 
Committed <http://trac.webkit.org/r169987>.