Bug 133913 - CSS JIT: add support for the :lang() pseudo class
Summary: CSS JIT: add support for the :lang() pseudo class
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Benjamin Poulain
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-06-14 14:02 PDT by Benjamin Poulain
Modified: 2014-06-15 23:54 PDT (History)
10 users (show)

See Also:

Attachments
Patch (26.29 KB, patch)
2014-06-14 14:04 PDT, Benjamin Poulain 		kling: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Benjamin Poulain 2014-06-14 14:02:00 PDT 
CSS JIT: add support for the :lang() pseudo class
Comment 1 Benjamin Poulain 2014-06-14 14:04:06 PDT 
Created attachment 233120 [details]
Patch
Comment 2 Alexey Proskuryakov 2014-06-14 14:44:12 PDT 
See also bug 16801.
Comment 3 Andreas Kling 2014-06-15 00:28:13 PDT 
Comment on attachment 233120 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=233120&action=review

r=me

> Source/WebCore/css/SelectorCheckerTestFunctions.h:118
> +    if (value.startsWith(String(*filter), false)) {

String(*filter) will ref() and unref() the StringImpl here, you can do better. :)
Comment 4 Benjamin Poulain 2014-06-15 23:54:49 PDT 
Committed r170001: <http://trac.webkit.org/changeset/170001>