Bug 133904 – convertToUTF8String converts null string to empty string

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Hamish Mackenzie]

This means it is not possible to use functions like webkit_dom_css_style_declaration_get_property_value to tell if a property has no value (or is just set to the empty string).

I think it could be fixed with...

 gchar* convertToUTF8String(WTF::String const& s)
 {
+    if (!s) return 0;
     return g_strdup(s.utf8().data());
 }

[Carlos Garcia Campos]

I agree, and it's consistent with the rest of the API that uses NULL instead of "". My only concern is that it might break existing applications relying on DOM functions returning always valid pointers. We have just broken the API/ABI so maybe it's a good momento for a change like this one, though.

[Alberto Garcia]

I guess if we really want to do this and it's not too late already, then it's now or never.

[Carlos Garcia Campos]

I had forgotten this, we should have changed it before the 2.6 release, but people are still migrating, s we can probably change it now.

[Alberto Garcia]

Created attachment 242899 [details]
Patch

[Alberto Garcia]

Created attachment 242928 [details]
Patch

I added a test

[Carlos Garcia Campos]

Comment on attachment 242928 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=242928&action=review

Thanks!

> Source/WebCore/bindings/gobject/ConvertToUTF8String.cpp:33
> +        return 0;

nullptr

> Source/WebCore/bindings/gobject/ConvertToUTF8String.cpp:35
>      return g_strdup(s.utf8().data());

We could probably do something like return s.isNull() ? nullptr : g_strdup(s.utf8().data());

[Carlos Garcia Campos]

We should merge this in the stable branch too.

[Alberto Garcia]

Committed r177019: <http://trac.webkit.org/changeset/177019>