Bug 133892 - Masks disappear when layers become tiled
Summary: Masks disappear when layers become tiled
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-06-13 19:39 PDT by Simon Fraser (smfr)
Modified: 2014-06-14 10:41 PDT (History)
5 users (show)

See Also:

Attachments
Patch (28.15 KB, patch)
2014-06-13 19:50 PDT, Simon Fraser (smfr) 		thorton: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2014-06-13 19:39:14 PDT 
Masks disappear when layers become tiled
Comment 1 Simon Fraser (smfr) 2014-06-13 19:50:55 PDT 
Created attachment 233099 [details]
Patch
Comment 2 Tim Horton 2014-06-13 21:13:58 PDT 
Comment on attachment 233099 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=233099&action=review

> Source/WebCore/ChangeLog:9
> +        There were several problems with tiled mask layers.

Nice!

> Source/WebCore/ChangeLog:22
> +            1. setting a bit on a layer to note that it's being used as a maks.

typo "maks"

> LayoutTests/compositing/masks/become-tiled-mask.html:35
> +    if (window.testRunner)

indentation of this script is wacky (some 2-space, some 4)
Comment 3 Simon Fraser (smfr) 2014-06-14 10:41:34 PDT 
https://trac.webkit.org/r169972