The GTK port only supports WebKit2. Therefore the --webkit-test-runner/-2 switch for Tools/Scripts/run-perf-tests should be always enabled on this platform.
Created attachment 232926 [details] Patch
Comment on attachment 232926 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=232926&action=review > Tools/Scripts/webkitpy/performance_tests/perftestsrunner.py:71 > + # The GTK+ port only supports WebKit2, so it always uses WKTR. > + if self._port.name().startswith("gtk"): > + self._options.webkit_test_runner = True Should we split out some warning about this?
(In reply to comment #2) > (From update of attachment 232926 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=232926&action=review > > > Tools/Scripts/webkitpy/performance_tests/perftestsrunner.py:71 > > + # The GTK+ port only supports WebKit2, so it always uses WKTR. > > + if self._port.name().startswith("gtk"): > > + self._options.webkit_test_runner = True > > Should we split out some warning about this? For example right now "run-launcher --gtk -2" fails and returns: Starting webkit launcher. Cannot parse arguments: Unknown option -2 I don't know what's the best approach, maybe simply showing a warning and using always WebKit2 is the best option. But I think we should be consistent and do the same in: run-launcher, run-webkit-tests and run-perf-tests. Of course, this can be done in different patches.
(In reply to comment #3) > (In reply to comment #2) > > (From update of attachment 232926 [details] [details]) > > View in context: https://bugs.webkit.org/attachment.cgi?id=232926&action=review > > > > > Tools/Scripts/webkitpy/performance_tests/perftestsrunner.py:71 > > > + # The GTK+ port only supports WebKit2, so it always uses WKTR. > > > + if self._port.name().startswith("gtk"): > > > + self._options.webkit_test_runner = True > > > > Should we split out some warning about this? > > For example right now "run-launcher --gtk -2" fails and returns: > Starting webkit launcher. > Cannot parse arguments: Unknown option -2 > > I don't know what's the best approach, maybe simply showing a warning and using always WebKit2 is the best option. > But I think we should be consistent and do the same in: run-launcher, run-webkit-tests and run-perf-tests. Of course, this can be done in different patches. The bots are going to keep passing "--webkit-test-runner/-2" because that is how are implemented the steps on Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg Making it fail when "-2/--webkit-test-runner" is passed will break the bots. And I'm not sure about the usefulness of showing a warning. run-webkit-tests also uses WKTR always with GTK+ and no warning is shown: <http://trac.webkit.org/changeset/167426>. So I think the current patch is consistent with that.
Comment on attachment 232926 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=232926&action=review >>>> Tools/Scripts/webkitpy/performance_tests/perftestsrunner.py:71 >>>> + self._options.webkit_test_runner = True >>> >>> Should we split out some warning about this? >> >> For example right now "run-launcher --gtk -2" fails and returns: >> Starting webkit launcher. >> Cannot parse arguments: Unknown option -2 >> >> I don't know what's the best approach, maybe simply showing a warning and using always WebKit2 is the best option. >> But I think we should be consistent and do the same in: run-launcher, run-webkit-tests and run-perf-tests. Of course, this can be done in different patches. > > The bots are going to keep passing "--webkit-test-runner/-2" because that is how are implemented the steps on Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg Making it fail when "-2/--webkit-test-runner" is passed will break the bots. > > And I'm not sure about the usefulness of showing a warning. run-webkit-tests also uses WKTR always with GTK+ and no warning is shown: <http://trac.webkit.org/changeset/167426>. So I think the current patch is consistent with that. Ok, fair enough. I didn't realize run-webkit-tests was fixed already. Maybe we could change run-launcher to use WebKit2 by default and not fail (maybe showing a warning in that particular case).
Comment on attachment 232926 [details] Patch Clearing flags on attachment: 232926 Committed r169893: <http://trac.webkit.org/changeset/169893>
All reviewed patches have been landed. Closing bug.