Bug 133780 - [GTK] Performance tests should be always ran with WKTR
Summary: [GTK] Performance tests should be always ran with WKTR
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-06-11 18:12 PDT by Carlos Alberto Lopez Perez
Modified: 2014-06-12 05:53 PDT (History)
13 users (show)

See Also:


Attachments
Patch (1.63 KB, patch)
2014-06-11 18:18 PDT, Carlos Alberto Lopez Perez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Alberto Lopez Perez 2014-06-11 18:12:45 PDT
The GTK port only supports WebKit2.

Therefore the --webkit-test-runner/-2 switch for Tools/Scripts/run-perf-tests should be always enabled on this platform.
Comment 1 Carlos Alberto Lopez Perez 2014-06-11 18:18:51 PDT
Created attachment 232926 [details]
Patch
Comment 2 Ryosuke Niwa 2014-06-11 22:13:43 PDT
Comment on attachment 232926 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=232926&action=review

> Tools/Scripts/webkitpy/performance_tests/perftestsrunner.py:71
> +        # The GTK+ port only supports WebKit2, so it always uses WKTR.
> +        if self._port.name().startswith("gtk"):
> +            self._options.webkit_test_runner = True

Should we split out some warning about this?
Comment 3 Manuel Rego Casasnovas 2014-06-12 00:18:44 PDT
(In reply to comment #2)
> (From update of attachment 232926 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=232926&action=review
> 
> > Tools/Scripts/webkitpy/performance_tests/perftestsrunner.py:71
> > +        # The GTK+ port only supports WebKit2, so it always uses WKTR.
> > +        if self._port.name().startswith("gtk"):
> > +            self._options.webkit_test_runner = True
> 
> Should we split out some warning about this?

For example right now "run-launcher --gtk -2" fails and returns:
Starting webkit launcher.
Cannot parse arguments: Unknown option -2

I don't know what's the best approach, maybe simply showing a warning and using always WebKit2 is the best option.
But I think we should be consistent and do the same in: run-launcher, run-webkit-tests and run-perf-tests. Of course, this can be done in different patches.
Comment 4 Carlos Alberto Lopez Perez 2014-06-12 04:47:07 PDT
(In reply to comment #3)
> (In reply to comment #2)
> > (From update of attachment 232926 [details] [details])
> > View in context: https://bugs.webkit.org/attachment.cgi?id=232926&action=review
> > 
> > > Tools/Scripts/webkitpy/performance_tests/perftestsrunner.py:71
> > > +        # The GTK+ port only supports WebKit2, so it always uses WKTR.
> > > +        if self._port.name().startswith("gtk"):
> > > +            self._options.webkit_test_runner = True
> > 
> > Should we split out some warning about this?
> 
> For example right now "run-launcher --gtk -2" fails and returns:
> Starting webkit launcher.
> Cannot parse arguments: Unknown option -2
> 
> I don't know what's the best approach, maybe simply showing a warning and using always WebKit2 is the best option.
> But I think we should be consistent and do the same in: run-launcher, run-webkit-tests and run-perf-tests. Of course, this can be done in different patches.


The bots are going to keep passing "--webkit-test-runner/-2" because that is how are implemented the steps on Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg Making it fail when "-2/--webkit-test-runner" is passed will break the bots.

And I'm not sure about the usefulness of showing a warning. run-webkit-tests also uses WKTR always with GTK+ and no warning is shown: <http://trac.webkit.org/changeset/167426>. So I think the current patch is consistent with that.
Comment 5 Manuel Rego Casasnovas 2014-06-12 05:23:30 PDT
Comment on attachment 232926 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=232926&action=review

>>>> Tools/Scripts/webkitpy/performance_tests/perftestsrunner.py:71
>>>> +            self._options.webkit_test_runner = True
>>> 
>>> Should we split out some warning about this?
>> 
>> For example right now "run-launcher --gtk -2" fails and returns:
>> Starting webkit launcher.
>> Cannot parse arguments: Unknown option -2
>> 
>> I don't know what's the best approach, maybe simply showing a warning and using always WebKit2 is the best option.
>> But I think we should be consistent and do the same in: run-launcher, run-webkit-tests and run-perf-tests. Of course, this can be done in different patches.
> 
> The bots are going to keep passing "--webkit-test-runner/-2" because that is how are implemented the steps on Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg Making it fail when "-2/--webkit-test-runner" is passed will break the bots.
> 
> And I'm not sure about the usefulness of showing a warning. run-webkit-tests also uses WKTR always with GTK+ and no warning is shown: <http://trac.webkit.org/changeset/167426>. So I think the current patch is consistent with that.

Ok, fair enough. I didn't realize run-webkit-tests was fixed already.

Maybe we could change run-launcher to use WebKit2 by default and not fail (maybe showing a warning in that particular case).
Comment 6 WebKit Commit Bot 2014-06-12 05:53:54 PDT
Comment on attachment 232926 [details]
Patch

Clearing flags on attachment: 232926

Committed r169893: <http://trac.webkit.org/changeset/169893>
Comment 7 WebKit Commit Bot 2014-06-12 05:53:59 PDT
All reviewed patches have been landed.  Closing bug.