Bug 133776 - Remove XHRReplayData::addHeader
Summary: Remove XHRReplayData::addHeader
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-06-11 16:51 PDT by Anders Carlsson
Modified: 2014-06-18 12:36 PDT (History)
0 users

See Also:

Attachments
Patch (5.10 KB, patch)
2014-06-11 16:52 PDT, Anders Carlsson 		koivisto: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2014-06-11 16:51:42 PDT 
Remove XHRReplayData::addHeader
Comment 1 Anders Carlsson 2014-06-11 16:52:53 PDT 
Created attachment 232920 [details]
Patch
Comment 2 Anders Carlsson 2014-06-11 16:58:06 PDT 
Committed r169861: <http://trac.webkit.org/changeset/169861>
Comment 3 Darin Adler 2014-06-18 12:36:58 PDT 
Comment on attachment 232920 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=232920&action=review

> Source/WebCore/inspector/InspectorResourceAgent.cpp:489
>      m_pendingXHRReplayData.set(client, xhrReplayData);

Shouldn’t this be calling xhrReplayData.release()?