Bug 133755 - Always inline JSValue::get() and Structure::get().
Summary: Always inline JSValue::get() and Structure::get().
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andreas Kling
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-06-11 12:20 PDT by Andreas Kling
Modified: 2014-06-11 14:28 PDT (History)
5 users (show)

See Also:

Attachments
Patch (4.75 KB, patch)
2014-06-11 12:23 PDT, Andreas Kling 		no flags Details | Formatted Diff | Diff
Patch for landing (4.28 KB, patch)
2014-06-11 12:36 PDT, Ryosuke Niwa 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2014-06-11 12:20:28 PDT 
GetByVal micro-optimization cont'd.
Comment 1 Andreas Kling 2014-06-11 12:23:19 PDT 
Created attachment 232887 [details]
Patch
Comment 2 Andreas Kling 2014-06-11 12:24:49 PDT 
On Ryosuke's microbenchmark from bug 133727:

46.78ms -> 35.70ms
46.64ms -> 35.61ms
Comment 3 Ryosuke Niwa 2014-06-11 12:25:59 PDT 
Comment on attachment 232887 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=232887&action=review

> Source/JavaScriptCore/ChangeLog:12
> +        Reviewed by NOBODY (OOPS!).

This line should appear right beneath the bug URL.
Comment 4 Ryosuke Niwa 2014-06-11 12:36:21 PDT 
Created attachment 232888 [details]
Patch for landing
Comment 5 WebKit Commit Bot 2014-06-11 13:17:13 PDT 
Comment on attachment 232888 [details]
Patch for landing

Clearing flags on attachment: 232888

Committed r169823: <http://trac.webkit.org/changeset/169823>
Comment 6 WebKit Commit Bot 2014-06-11 13:17:17 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 7 Csaba Osztrogonác 2014-06-11 14:28:58 PDT 
buildfix landed in r169834.