WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
133753
Change the order of the alias analysis passes to align with the opt pipeline of LLVM
https://bugs.webkit.org/show_bug.cgi?id=133753
Summary
Change the order of the alias analysis passes to align with the opt pipeline ...
Juergen Ributzka
Reported
2014-06-11 11:45:42 PDT
Change the order of the alias analysis passes to align with the opt pipeline of LLVM
Attachments
Patch
(1.98 KB, patch)
2014-06-11 11:55 PDT
,
Juergen Ributzka
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Juergen Ributzka
Comment 1
2014-06-11 11:55:35 PDT
Created
attachment 232880
[details]
Patch
Geoffrey Garen
Comment 2
2014-06-11 12:41:39 PDT
Comment on
attachment 232880
[details]
Patch Seems reasonable. Is this a speedup, or just a cleanup?
Juergen Ributzka
Comment 3
2014-06-11 12:45:27 PDT
I didn't check if there is a speedup, but I feel more comfortable using an order that is used and tested by the default LLVM opt pipeline.
Andrew Trick
Comment 4
2014-06-12 20:27:00 PDT
The AA implementations are queried in reverse order, last added, first queried. For C++, we query BasicAA first for correctness. It may actually disagree with TBAA! If TBAA says objects can't alias, but they are obviously derived from the same pointer, then TBAA is wrong and we want to catch that. For JS, that's not an issue and it makes sense to query TBAA first instead since it is probably faster. However, if we can't measure any compile time difference, then I agree with Juergen, that it's a bit less risky to be consistent with the C++ optimizer.
WebKit Commit Bot
Comment 5
2014-06-16 12:28:18 PDT
Comment on
attachment 232880
[details]
Patch Clearing flags on attachment: 232880 Committed
r170022
: <
http://trac.webkit.org/changeset/170022
>
WebKit Commit Bot
Comment 6
2014-06-16 12:28:20 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug