Bug 133684 - Send more context about text selection to telephone number scanner
Summary: Send more context about text selection to telephone number scanner
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac All
: P2 Normal
Assignee: Brady Eidson
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2014-06-10 10:39 PDT by Brady Eidson
Modified: 2014-06-10 10:53 PDT (History)
0 users

See Also:

Attachments
Patch v1 (5.34 KB, patch)
2014-06-10 10:42 PDT, Brady Eidson 		enrica: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brady Eidson 2014-06-10 10:39:06 PDT 
Send more context about text selection to telephone number scanner

By sending a few characters before and after the selection we can detect phone numbers before they are completely selected.

In radar <rdar://problem/16874385>
Comment 1 Brady Eidson 2014-06-10 10:42:53 PDT 
Created attachment 232795 [details]
Patch v1
Comment 2 Enrica Casucci 2014-06-10 10:48:20 PDT 
Comment on attachment 232795 [details]
Patch v1

Looks good to me.
Comment 3 Brady Eidson 2014-06-10 10:53:00 PDT 
http://trac.webkit.org/changeset/169750