Bug 133675 - Use braced-init-list to create one-item Vector object in insertPerformanceEntry
Summary: Use braced-init-list to create one-item Vector object in insertPerformanceEntry
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Zan Dobersek
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-06-09 22:57 PDT by Zan Dobersek
Modified: 2014-07-12 17:20 PDT (History)
3 users (show)

See Also:

Attachments
Patch (1.82 KB, patch)
2014-06-09 23:00 PDT, Zan Dobersek 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from webkit-ews-06 for mac-mountainlion (577.55 KB, application/zip)
2014-06-10 00:28 PDT, Build Bot 		no flags Details
Archive of layout-test-results from webkit-ews-16 for mac-mountainlion-wk2 (633.79 KB, application/zip)
2014-06-10 00:38 PDT, Build Bot 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Zan Dobersek 2014-06-09 22:57:34 PDT 
Use braced-init-list to create one-item Vector object in insertPerformanceEntry
Comment 1 Zan Dobersek 2014-06-09 23:00:50 PDT 
Created attachment 232770 [details]
Patch
Comment 2 WebKit Commit Bot 2014-06-09 23:03:50 PDT 
Attachment 232770 [details] did not pass style-queue:


ERROR: Source/WebCore/page/PerformanceUserTiming.cpp:85:  Missing space before {  [whitespace/braces] [5]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Build Bot 2014-06-10 00:28:25 PDT 
Comment on attachment 232770 [details]
Patch

Attachment 232770 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/4666002658820096

New failing tests:
media/track/w3c/interfaces/TextTrackCue/id.html
media/track/w3c/interfaces/TextTrackCue/pauseOnExit.html
media/track/w3c/interfaces/TextTrackCue/track.html
media/track/w3c/interfaces/TextTrackCue/startTime.html
media/track/w3c/interfaces/TextTrackCue/endTime.html
media/track/w3c/interfaces/TextTrackCue/align.html
Comment 4 Build Bot 2014-06-10 00:28:27 PDT 
Created attachment 232777 [details]
Archive of layout-test-results from webkit-ews-06 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-06  Port: mac-mountainlion  Platform: Mac OS X 10.8.5
Comment 5 Build Bot 2014-06-10 00:38:56 PDT 
Comment on attachment 232770 [details]
Patch

Attachment 232770 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/4676323196796928

New failing tests:
media/W3C/video/networkState/networkState_during_loadstart.html
Comment 6 Build Bot 2014-06-10 00:38:59 PDT 
Created attachment 232779 [details]
Archive of layout-test-results from webkit-ews-16 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-16  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5
Comment 7 WebKit Commit Bot 2014-07-12 17:20:04 PDT 
Comment on attachment 232770 [details]
Patch

Clearing flags on attachment: 232770

Committed r171037: <http://trac.webkit.org/changeset/171037>
Comment 8 WebKit Commit Bot 2014-07-12 17:20:08 PDT 
All reviewed patches have been landed.  Closing bug.