Bug 133674 - Avoid FontGlyphsCacheKey copy in FontGlyphsCacheEntry constructor
Summary: Avoid FontGlyphsCacheKey copy in FontGlyphsCacheEntry constructor
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Zan Dobersek
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-06-09 22:46 PDT by Zan Dobersek
Modified: 2014-06-11 05:21 PDT (History)
1 user (show)

See Also:

Attachments
Patch (1.58 KB, patch)
2014-06-09 22:48 PDT, Zan Dobersek 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Zan Dobersek 2014-06-09 22:46:14 PDT 
Avoid FontGlyphsCacheKey copy in FontGlyphsCacheEntry constructor
Comment 1 Zan Dobersek 2014-06-09 22:48:39 PDT 
Created attachment 232769 [details]
Patch
Comment 2 WebKit Commit Bot 2014-06-09 22:50:42 PDT 
Attachment 232769 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/graphics/Font.cpp:218:  Should be indented on a separate line, with the colon or comma first on that line.  [whitespace/indent] [4]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Zan Dobersek 2014-06-11 05:21:18 PDT 
Comment on attachment 232769 [details]
Patch

Clearing flags on attachment: 232769

Committed r169802: <http://trac.webkit.org/changeset/169802>
Comment 4 Zan Dobersek 2014-06-11 05:21:25 PDT 
All reviewed patches have been landed.  Closing bug.