Bug 133598 - [Mac] caption size is not update immediately when system preferences change
Summary: [Mac] caption size is not update immediately when system preferences change
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Eric Carlson
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2014-06-06 19:09 PDT by Eric Carlson
Modified: 2014-06-09 14:04 PDT (History)
12 users (show)

See Also:

Attachments
Proposed patch. (4.01 KB, patch)
2014-06-06 19:15 PDT, Eric Carlson 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from webkit-ews-15 for mac-mountainlion-wk2 (479.70 KB, application/zip)
2014-06-06 20:16 PDT, Build Bot 		no flags Details
Archive of layout-test-results from webkit-ews-08 for mac-mountainlion (501.39 KB, application/zip)
2014-06-06 20:40 PDT, Build Bot 		no flags Details
Archive of layout-test-results from webkit-ews-05 for mac-mountainlion (501.33 KB, application/zip)
2014-06-06 21:39 PDT, Build Bot 		no flags Details
Updated patch. (2.65 KB, patch)
2014-06-09 11:00 PDT, Eric Carlson 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Carlson 2014-06-06 19:09:06 PDT 
Changing the system preference for caption size does not immediately update caption size.
Comment 1 Eric Carlson 2014-06-06 19:09:31 PDT 
<rdar://problem/17039796>
Comment 2 Eric Carlson 2014-06-06 19:15:33 PDT 
Created attachment 232644 [details]
Proposed patch.
Comment 3 Build Bot 2014-06-06 20:16:51 PDT 
Comment on attachment 232644 [details]
Proposed patch.

Attachment 232644 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/6008604066840576

New failing tests:
media/track/regions-webvtt/vtt-region-display.html
Comment 4 Build Bot 2014-06-06 20:16:57 PDT 
Created attachment 232645 [details]
Archive of layout-test-results from webkit-ews-15 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-15  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5
Comment 5 Build Bot 2014-06-06 20:39:54 PDT 
Comment on attachment 232644 [details]
Proposed patch.

Attachment 232644 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/6151001023184896

New failing tests:
media/track/regions-webvtt/vtt-region-display.html
Comment 6 Build Bot 2014-06-06 20:40:00 PDT 
Created attachment 232647 [details]
Archive of layout-test-results from webkit-ews-08 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-08  Port: mac-mountainlion  Platform: Mac OS X 10.8.5
Comment 7 Build Bot 2014-06-06 21:39:31 PDT 
Comment on attachment 232644 [details]
Proposed patch.

Attachment 232644 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/4624696884592640

New failing tests:
media/track/regions-webvtt/vtt-region-display.html
Comment 8 Build Bot 2014-06-06 21:39:36 PDT 
Created attachment 232652 [details]
Archive of layout-test-results from webkit-ews-05 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-05  Port: mac-mountainlion  Platform: Mac OS X 10.8.5
Comment 9 Jer Noble 2014-06-09 10:44:45 PDT 
Comment on attachment 232644 [details]
Proposed patch.

r=me, but you may want to look into the vtt test failure.  It may just need a rebaseline.
Comment 10 Eric Carlson 2014-06-09 11:00:15 PDT 
Created attachment 232714 [details]
Updated patch.
Comment 11 WebKit Commit Bot 2014-06-09 12:39:58 PDT 
Comment on attachment 232714 [details]
Updated patch.

Rejecting attachment 232714 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-03', 'validate-changelog', '--check-oops', '--non-interactive', 232714, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

ChangeLog entry in Source/WebCore/ChangeLog contains OOPS!.

Full output: http://webkit-queues.appspot.com/results/5780000942850048
Comment 12 Brent Fulgham 2014-06-09 13:32:44 PDT 
Comment on attachment 232714 [details]
Updated patch.

r=me.
Comment 13 WebKit Commit Bot 2014-06-09 14:03:55 PDT 
Comment on attachment 232714 [details]
Updated patch.

Clearing flags on attachment: 232714

Committed r169713: <http://trac.webkit.org/changeset/169713>
Comment 14 WebKit Commit Bot 2014-06-09 14:04:01 PDT 
All reviewed patches have been landed.  Closing bug.