Bug 133598 – [Mac] caption size is not update immediately when system preferences change

• Status: RESOLVED
• Resolution: FIXED
• Component: Media

[Eric Carlson]

Changing the system preference for caption size does not immediately update caption size.

[Eric Carlson]

<rdar://problem/17039796>

[Eric Carlson]

Created attachment 232644 [details]
Proposed patch.

[Build Bot]

Comment on attachment 232644 [details]
Proposed patch.

Attachment 232644 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/6008604066840576

New failing tests:
media/track/regions-webvtt/vtt-region-display.html

[Build Bot]

Created attachment 232645 [details]
Archive of layout-test-results from webkit-ews-15 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-15  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5

[Build Bot]

Comment on attachment 232644 [details]
Proposed patch.

Attachment 232644 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/6151001023184896

New failing tests:
media/track/regions-webvtt/vtt-region-display.html

[Build Bot]

Created attachment 232647 [details]
Archive of layout-test-results from webkit-ews-08 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-08  Port: mac-mountainlion  Platform: Mac OS X 10.8.5

[Build Bot]

Comment on attachment 232644 [details]
Proposed patch.

Attachment 232644 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/4624696884592640

New failing tests:
media/track/regions-webvtt/vtt-region-display.html

[Build Bot]

Created attachment 232652 [details]
Archive of layout-test-results from webkit-ews-05 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-05  Port: mac-mountainlion  Platform: Mac OS X 10.8.5

[Jer Noble]

Comment on attachment 232644 [details]
Proposed patch.

r=me, but you may want to look into the vtt test failure.  It may just need a rebaseline.

[Eric Carlson]

Created attachment 232714 [details]
Updated patch.

[WebKit Commit Bot]

Comment on attachment 232714 [details]
Updated patch.

Rejecting attachment 232714 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-03', 'validate-changelog', '--check-oops', '--non-interactive', 232714, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

ChangeLog entry in Source/WebCore/ChangeLog contains OOPS!.

Full output: http://webkit-queues.appspot.com/results/5780000942850048

[Brent Fulgham]

Comment on attachment 232714 [details]
Updated patch.

r=me.

[WebKit Commit Bot]

Comment on attachment 232714 [details]
Updated patch.

Clearing flags on attachment: 232714

Committed r169713: <http://trac.webkit.org/changeset/169713>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.