WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
133597
Improve CSSPrimitiveValue::customCSSText for ARMv7
https://bugs.webkit.org/show_bug.cgi?id=133597
Summary
Improve CSSPrimitiveValue::customCSSText for ARMv7
Benjamin Poulain
Reported
2014-06-06 18:21:32 PDT
Improve CSSPrimitiveValue::customCSSText for ARMv7
Attachments
Patch
(22.95 KB, patch)
2014-06-06 18:43 PDT
,
Benjamin Poulain
kling
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Benjamin Poulain
Comment 1
2014-06-06 18:43:08 PDT
Created
attachment 232642
[details]
Patch
WebKit Commit Bot
Comment 2
2014-06-06 18:44:26 PDT
Attachment 232642
[details]
did not pass style-queue: ERROR: Source/WTF/wtf/text/WTFString.h:118: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] Total errors found: 1 in 6 files If any of these errors are false positives, please file a bug against check-webkit-style.
Benjamin Poulain
Comment 3
2014-06-06 20:40:17 PDT
<
rdar://problem/17209984
>
Andreas Kling
Comment 4
2014-06-09 14:11:40 PDT
Comment on
attachment 232642
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=232642&action=review
r=me
> Source/WebCore/css/CSSPrimitiveValue.cpp:1151 > + return cssTextCache().get(this);
We should make sure to do cssTextCache() only once in this function.
Benjamin Poulain
Comment 5
2014-06-09 17:23:17 PDT
Committed
r169731
: <
http://trac.webkit.org/changeset/169731
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug