Bug 133597 - Improve CSSPrimitiveValue::customCSSText for ARMv7
Summary: Improve CSSPrimitiveValue::customCSSText for ARMv7
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Benjamin Poulain
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2014-06-06 18:21 PDT by Benjamin Poulain
Modified: 2014-06-09 17:23 PDT (History)
9 users (show)

See Also:

Attachments
Patch (22.95 KB, patch)
2014-06-06 18:43 PDT, Benjamin Poulain 		kling: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Benjamin Poulain 2014-06-06 18:21:32 PDT 
Improve CSSPrimitiveValue::customCSSText for ARMv7
Comment 1 Benjamin Poulain 2014-06-06 18:43:08 PDT 
Created attachment 232642 [details]
Patch
Comment 2 WebKit Commit Bot 2014-06-06 18:44:26 PDT 
Attachment 232642 [details] did not pass style-queue:


ERROR: Source/WTF/wtf/text/WTFString.h:118:  Should be indented on a separate line, with the colon or comma first on that line.  [whitespace/indent] [4]
Total errors found: 1 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Benjamin Poulain 2014-06-06 20:40:17 PDT 
<rdar://problem/17209984>
Comment 4 Andreas Kling 2014-06-09 14:11:40 PDT 
Comment on attachment 232642 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=232642&action=review

r=me

> Source/WebCore/css/CSSPrimitiveValue.cpp:1151
> +        return cssTextCache().get(this);

We should make sure to do cssTextCache() only once in this function.
Comment 5 Benjamin Poulain 2014-06-09 17:23:17 PDT 
Committed r169731: <http://trac.webkit.org/changeset/169731>