Bug 133517 – [GTK] 4 of the css3/viewport-percentage-lengths/viewport-percentage-lengths-.*.html tests time out

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Carlos Alberto Lopez Perez]

The following tests ( added on http://trac.webkit.org/changeset/169407 ) time out on GTK:

css3/viewport-percentage-lengths/viewport-percentage-lengths-anonymous-block.html
css3/viewport-percentage-lengths/viewport-percentage-lengths-percent-size-child.html
css3/viewport-percentage-lengths/viewport-percentage-lengths-relative-font-size.html
css3/viewport-percentage-lengths/viewport-percentage-lengths-resize.html


The tests timeout always when the tests are run inside Xvfb (this is the default, and what the GTK bots do).

But when you run them on a real X server (this is done by exporting the environment variable USE_NATIVE_XDISPLAY) some of them pass:

$ USE_NATIVE_XDISPLAY=1 Tools/Scripts/run-webkit-tests --release --webkit-test-runner --gtk css3/viewport-percentage-lengths/viewport-percentage-lengths-anonymous-block.html css3/viewport-percentage-lengths/viewport-percentage-lengths-percent-size-child.html css3/viewport-percentage-lengths/viewport-percentage-lengths-relative-font-size.html css3/viewport-percentage-lengths/viewport-percentage-lengths-resize.html
Using port 'gtk-wk2'
Test configuration: <, x86, release>
Placing test results in /home/clopez/webkit/webkit/WebKitBuild/Release/layout-test-results
Baseline search path: gtk-wk2 -> wk2 -> gtk -> generic
Using Release build
Pixel tests disabled
Regular timeout: 6000, slow test timeout: 30000
Command line: /home/clopez/webkit/webkit/WebKitBuild/Release/bin/WebKitTestRunner -

Found 4 tests; running 4, skipping 0.
Running 1 WebKitTestRunner.     

[1/4] css3/viewport-percentage-lengths/viewport-percentage-lengths-anonymous-block.html failed unexpectedly (test timed out)
[3/4] css3/viewport-percentage-lengths/viewport-percentage-lengths-relative-font-size.html failed unexpectedly (test timed out)

Retrying 2 unexpected failure(s) ...

Running 1 WebKitTestRunner.

[2/2] css3/viewport-percentage-lengths/viewport-percentage-lengths-relative-font-size.html failed unexpectedly (test timed out)

2 tests ran as expected, 2 didn't:


Unexpected flakiness: timeouts (1)
  css3/viewport-percentage-lengths/viewport-percentage-lengths-anonymous-block.html [ Timeout Pass ]


Regressions: Unexpected timeouts (1)
  css3/viewport-percentage-lengths/viewport-percentage-lengths-relative-font-size.html [ Timeout ]


Maybe this information can be useful.

I tried to run the tests with --no-timeout and also with --time-out-ms=30000 (30 secs), but the behaviour is the same. They timeout always with Xvfb.

[Bem Jones-Bey]

I'm betting those are timing out because the onresize event doesn't fire in DRT/WTR on the GTK+ port. Darin fixed DRT/WTR for the Mac port in Bug 133351 when he changed the tests to use the onresize event. He made an attempt to fix the other ports as well, but it is possible that fix didn't work for the GTK port. Hopefully it's an easy fix.

[Carlos Alberto Lopez Perez]

Created attachment 233235 [details]
Patch

[Martin Robinson]

Comment on attachment 233235 [details]
Patch

Awesome!

[WebKit Commit Bot]

Comment on attachment 233235 [details]
Patch

Clearing flags on attachment: 233235

Committed r170058: <http://trac.webkit.org/changeset/170058>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[WebKit Commit Bot]

Re-opened since this is blocked by bug 133993

[Carlos Alberto Lopez Perez]

(In reply to comment #6)
> Re-opened since this is blocked by bug 133993

Ups! Forgot to update the resolution for the unit tests of Xvfb. I will upload an updated patch.

[Carlos Alberto Lopez Perez]

Created attachment 233261 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 233261 [details]
Patch

Clearing flags on attachment: 233261

Committed r170078: <http://trac.webkit.org/changeset/170078>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.