Bug 133201 - Subpixel rendering: Make webkit-box-shadow painting subpixel aware.
Summary: Subpixel rendering: Make webkit-box-shadow painting subpixel aware.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar, Regression
Depends on:
Blocks:
 
Reported: 2014-05-22 21:18 PDT by zalan
Modified: 2014-05-23 07:27 PDT (History)
7 users (show)

See Also:

Attachments
Patch (42.75 KB, patch)
2014-05-22 21:37 PDT, zalan 		no flags Details | Formatted Diff | Diff
Patch (42.81 KB, patch)
2014-05-22 21:40 PDT, zalan 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from webkit-ews-13 for mac-mountainlion-wk2 (549.73 KB, application/zip)
2014-05-22 23:41 PDT, Build Bot 		no flags Details
Patch (42.81 KB, patch)
2014-05-23 06:50 PDT, zalan 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2014-05-22 21:18:48 PDT 
This is just the painting part. webkit-box-shadow does not take fractional values atm (it truncates them)
Comment 1 zalan 2014-05-22 21:19:09 PDT 
<rdar://problem/16072830>
Comment 2 zalan 2014-05-22 21:37:39 PDT 
Created attachment 231938 [details]
Patch
Comment 3 zalan 2014-05-22 21:40:04 PDT 
Created attachment 231939 [details]
Patch
Comment 4 Build Bot 2014-05-22 23:41:19 PDT 
Comment on attachment 231939 [details]
Patch

Attachment 231939 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/6570820050616320

New failing tests:
media/media-fragments/TC0001.html
Comment 5 Build Bot 2014-05-22 23:41:22 PDT 
Created attachment 231946 [details]
Archive of layout-test-results from webkit-ews-13 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-13  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5
Comment 6 zalan 2014-05-23 06:50:12 PDT 
Created attachment 231962 [details]
Patch
Comment 7 WebKit Commit Bot 2014-05-23 07:27:49 PDT 
Comment on attachment 231962 [details]
Patch

Clearing flags on attachment: 231962

Committed r169257: <http://trac.webkit.org/changeset/169257>
Comment 8 WebKit Commit Bot 2014-05-23 07:27:53 PDT 
All reviewed patches have been landed.  Closing bug.