Bug 133153 - [EFL] Turn on ENABLE_CSS_FILTERS
Summary: [EFL] Turn on ENABLE_CSS_FILTERS
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Michal Pakula vel Rutka
URL:
Keywords:
: 124417 124516 124517 124519 (view as bug list)
Depends on:
Blocks:
 
Reported: 2014-05-21 05:37 PDT by Michal Pakula vel Rutka
Modified: 2014-05-26 08:20 PDT (History)
11 users (show)

See Also:

Attachments
proposed patch (6.36 KB, patch)
2014-05-21 06:45 PDT, Michal Pakula vel Rutka 		gyuyoung.kim: review+
Details | Formatted Diff | Diff
patch for landing (6.38 KB, patch)
2014-05-21 07:51 PDT, Michal Pakula vel Rutka 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michal Pakula vel Rutka 2014-05-21 05:37:11 PDT 
As there was a discussion to remove ENABLE_FILTERS and ENABLE_CSS_FILTERS on webkit-dev (https://lists.webkit.org/pipermail/webkit-dev/2014-May/026553.html), we should turn on CSS_FILTERS in EFL port.
Comment 1 Michal Pakula vel Rutka 2014-05-21 06:45:11 PDT 
Created attachment 231823 [details]
proposed patch
Comment 2 Gyuyoung Kim 2014-05-21 07:45:14 PDT 
Comment on attachment 231823 [details]
proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=231823&action=review

> Source/cmake/OptionsEfl.cmake:60
> +WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_CSS_FILTERS ON)

Looks wrong alphabet order. Please fix it before landing.
Comment 3 Michal Pakula vel Rutka 2014-05-21 07:51:00 PDT 
Created attachment 231828 [details]
patch for landing
Comment 4 WebKit Commit Bot 2014-05-21 11:22:57 PDT 
Comment on attachment 231828 [details]
patch for landing

Clearing flags on attachment: 231828

Committed r169172: <http://trac.webkit.org/changeset/169172>
Comment 5 WebKit Commit Bot 2014-05-21 11:23:03 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 6 Michal Pakula vel Rutka 2014-05-26 08:19:43 PDT 
*** Bug 124417 has been marked as a duplicate of this bug. ***
Comment 7 Michal Pakula vel Rutka 2014-05-26 08:20:27 PDT 
*** Bug 124517 has been marked as a duplicate of this bug. ***
Comment 8 Michal Pakula vel Rutka 2014-05-26 08:20:33 PDT 
*** Bug 124516 has been marked as a duplicate of this bug. ***
Comment 9 Michal Pakula vel Rutka 2014-05-26 08:20:41 PDT 
*** Bug 124519 has been marked as a duplicate of this bug. ***