Bug 133022 - Split scrolling tree ScrollingNodes into FrameScrollingNodes and OverflowScrollingNodes
Summary: Split scrolling tree ScrollingNodes into FrameScrollingNodes and OverflowScro...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords:
Depends on:
Blocks: 172349
  Show dependency tree / graph
 
Reported: 2014-05-16 18:42 PDT by Simon Fraser (smfr)
Modified: 2017-05-19 01:04 PDT (History)
16 users (show)

See Also:

Attachments
Patch (278.39 KB, patch)
2014-05-16 18:49 PDT, Simon Fraser (smfr) 		no flags Details | Formatted Diff | Diff
EWS for EFL (279.06 KB, patch)
2014-05-19 11:06 PDT, Simon Fraser (smfr) 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2014-05-16 18:42:07 PDT 
Split scrolling tree ScrollingNodes into FrameScrollingNodes and OverflowScrollingNodes
Comment 1 Simon Fraser (smfr) 2014-05-16 18:49:07 PDT 
Created attachment 231612 [details]
Patch
Comment 2 WebKit Commit Bot 2014-05-16 18:50:28 PDT 
Attachment 231612 [details] did not pass style-queue:


ERROR: Source/WebKit2/Shared/Scrolling/RemoteScrollingCoordinatorTransaction.cpp:167:  Multi line control clauses should use braces.  [whitespace/braces] [4]
ERROR: Source/WebKit2/Shared/Scrolling/RemoteScrollingCoordinatorTransaction.cpp:175:  Multi line control clauses should use braces.  [whitespace/braces] [4]
Total errors found: 2 in 56 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Simon Fraser (smfr) 2014-05-19 11:06:25 PDT 
Created attachment 231703 [details]
EWS for EFL
Comment 4 WebKit Commit Bot 2014-05-19 11:09:40 PDT 
Attachment 231703 [details] did not pass style-queue:


ERROR: Source/WebKit2/Shared/Scrolling/RemoteScrollingCoordinatorTransaction.cpp:167:  Multi line control clauses should use braces.  [whitespace/braces] [4]
ERROR: Source/WebKit2/Shared/Scrolling/RemoteScrollingCoordinatorTransaction.cpp:175:  Multi line control clauses should use braces.  [whitespace/braces] [4]
Total errors found: 2 in 57 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 Simon Fraser (smfr) 2014-05-19 13:42:35 PDT 
http://trac.webkit.org/changeset/169063
Comment 6 Andreas Kling 2014-05-19 14:04:53 PDT 
Comment on attachment 231703 [details]
EWS for EFL

Removing from review queue since this already landed.