WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
132937
[iOS][WK2] Add a heuristic to set the rigth horizontal offset on rotation for broken responsive websites
https://bugs.webkit.org/show_bug.cgi?id=132937
Summary
[iOS][WK2] Add a heuristic to set the rigth horizontal offset on rotation for...
Benjamin Poulain
Reported
2014-05-14 20:39:42 PDT
[iOS][WK2] Add a heuristic to set the rigth horizontal offset on rotation for broken responsive websites
Attachments
Patch
(2.69 KB, patch)
2014-05-14 20:42 PDT
,
Benjamin Poulain
simon.fraser
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Benjamin Poulain
Comment 1
2014-05-14 20:42:36 PDT
Created
attachment 231484
[details]
Patch
Benjamin Poulain
Comment 2
2014-05-14 20:43:34 PDT
<
rdar://problem/16710097
>
Simon Fraser (smfr)
Comment 3
2014-05-15 15:59:13 PDT
Comment on
attachment 231484
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=231484&action=review
> Source/WebKit2/ChangeLog:9 > + When responsive websites are broken, we should not keep the relative horizontal position into view,
It's not clear what "When responsive websites are broken" means. Broken by us, or broken by design? "keep the position into view" doesn't make sense.
Simon Fraser (smfr)
Comment 4
2014-05-15 16:00:48 PDT
Comment on
attachment 231484
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=231484&action=review
> Source/WebKit2/ChangeLog:3 > + [iOS][WK2] Add a heuristic to set the rigth horizontal offset on rotation for broken responsive websites
"rigth"
Simon Fraser (smfr)
Comment 5
2014-05-15 16:05:19 PDT
Comment on
attachment 231484
[details]
Patch Let's remove the "broken responsive" terminology.
Benjamin Poulain
Comment 6
2014-05-16 14:58:26 PDT
Committed
r168982
: <
http://trac.webkit.org/changeset/168982
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug